r88722 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88721‎ | r88722 | r88723 >
Date:16:04, 24 May 2011
Author:reedy
Status:reverted
Tags:
Comment:
* (bug 29120) ApiQueryLogEvents: let letype accept multiple values

Description already hinted at multiple
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryLogEvents.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -90,6 +90,7 @@
9191 title inputs
9292 * (bug 20699) API watchlist should list log-events
9393 * (bug 29070) Add token to action=watch
 94+* (bug 29120) ApiQueryLogEvents: let letype accept multiple values
9495
9596 === Languages updated in 1.19 ===
9697
Index: trunk/phase3/includes/api/ApiQueryLogEvents.php
@@ -114,8 +114,7 @@
115115 list( $type, $action ) = explode( '/', $params['action'] );
116116 $this->addWhereFld( 'log_type', $type );
117117 $this->addWhereFld( 'log_action', $action );
118 - }
119 - else if ( !is_null( $params['type'] ) ) {
 118+ } else if ( !is_null( $params['type'] ) ) {
120119 $this->addWhereFld( 'log_type', $params['type'] );
121120 $index['logging'] = 'type_time';
122121 }
@@ -374,7 +373,8 @@
375374 )
376375 ),
377376 'type' => array(
378 - ApiBase::PARAM_TYPE => $wgLogTypes
 377+ ApiBase::PARAM_TYPE => $wgLogTypes,
 378+ ApiBase::PARAM_ISMULTI => true,
379379 ),
380380 'action' => array(
381381 ApiBase::PARAM_TYPE => array_keys( $wgLogActions )

Follow-up revisions

RevisionCommit summaryAuthorDate
r89348Revert r88722 (allow multiple values for letype): this won't play nice with q...catrope16:13, 2 June 2011
r95067Revert r95058 (make letype multivalue): has been applied before in r88722 and...catrope07:19, 20 August 2011

Status & tagging log