r88083 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88082‎ | r88083 | r88084 >
Date:14:14, 14 May 2011
Author:dale
Status:deferred
Tags:
Comment:
Some fixes for passing $options arguments around
Modified paths:
  • /trunk/extensions/TimedMediaHandler/WebVideoTranscode/WebVideoTranscode.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/WebVideoTranscode/WebVideoTranscode.php
@@ -173,7 +173,7 @@
174174 * Static function to get the set of video assets
175175 * Checks if the file is local or remote and grabs respective sources
176176 */
177 - static public function getSources( &$file , $options=array() ){
 177+ static public function getSources( &$file , $options = array() ){
178178 if( $file->isLocal() ){
179179 return self::getLocalSources( $file , $options );
180180 }else {
@@ -185,7 +185,7 @@
186186 *
187187 * Because this works on both TimedMediaHandler commons and no TimedMediaHandler commons
188188 */
189 - static public function getRemoteSources(&$file , $options=array() ){
 189+ static public function getRemoteSources(&$file , $options = array() ){
190190 global $wgMemc;
191191 // Setup source attribute options
192192 $dataPrefix = in_array( 'nodata', $options )? '': 'data-';
@@ -394,7 +394,7 @@
395395 /**
396396 * Get the primary "source" asset used for other derivatives
397397 */
398 - static public function getPrimarySourceAttributes($file, $options){
 398+ static public function getPrimarySourceAttributes($file, $options = array() ){
399399 global $wgLang;
400400 // Setup source attribute options
401401 $dataPrefix = in_array( 'nodata', $options )? '': 'data-';
@@ -428,7 +428,7 @@
429429 /**
430430 * Get derivative "source" attributes
431431 */
432 - static public function getDerivativeSourceAttributes($file, $transcodeKey, $options){
 432+ static public function getDerivativeSourceAttributes($file, $transcodeKey, $options = array() ){
433433 $dataPrefix = in_array( 'nodata', $options )? '': 'data-';
434434
435435

Status & tagging log