r90692 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90691‎ | r90692 | r90693 >
Date:07:08, 24 June 2011
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
Minor code cleanups
Modified paths:
  • /trunk/phase3/includes/specials/SpecialPrefixindex.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialPrefixindex.php
@@ -56,18 +56,17 @@
5757 );
5858
5959 $showme = '';
60 - if ( $this->including() && ( $par == '' ) ) {
 60+ if ( $this->including() && $par == '' ) {
6161 // Bug 27864: if transcluded, show all pages instead of the form
62 - $showme = ' ';
63 - } elseif( isset( $par ) ){
 62+ } elseif( isset( $par ) ) {
6463 $showme = $par;
65 - } elseif( $prefix != '' ){
 64+ } elseif( $prefix != '' ) {
6665 $showme = $prefix;
67 - } elseif( $from != '' ){
 66+ } elseif( $from != '' ) {
6867 // For back-compat with Special:Allpages
6968 $showme = $from;
7069 }
71 - if ($showme != '' || $namespace) {
 70+ if ( $showme != '' || $namespace ) {
7271 $this->showPrefixChunk( $namespace, $showme, $from );
7372 } else {
7473 $wgOut->addHTML( $this->namespacePrefixForm( $namespace, null ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r90724* More cleanups for r88084 (and fixed r90692)....aaron19:22, 24 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88084(bug 27864) Transcluding {{Special:Prefix}} with empty prefix now lists all p...btongminh14:15, 14 May 2011

Comments

#Comment by Siebrand (talk | contribs)   09:42, 24 June 2011

You removed "$showme = ' ';" (which is different from the default empty string per bug 27864). Does this not change behaviour?

#Comment by Aaron Schulz (talk | contribs)   18:49, 24 June 2011

You're right, I thought it was , not ' '. This seems hacky then, I'll see if there is some other way to do this.

Status & tagging log