r62968 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62967‎ | r62968 | r62969 >
Date:17:50, 25 February 2010
Author:maxsem
Status:ok
Tags:
Comment:
fix debug logging from r62967
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUserlogout.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserlogout.php
@@ -14,8 +14,8 @@
1515 * Some satellite ISPs use broken precaching schemes that log people out straight after
1616 * they're logged in (bug 17790). Luckily, there's a way to detect such requests.
1717 */
18 - wfDebug( $_SERVER['REQUEST_URI'] . "\n" );
1918 if ( isset( $_SERVER['REQUEST_URI'] ) && strpos( $_SERVER['REQUEST_URI'], '&' ) !== false ) {
 19+ wfDebug( "Special:Userlogout request {$_SERVER['REQUEST_URI']} looks suspicious, denying.\n" );
2020 wfHttpError( 400, wfMsg( 'loginerror' ), wfMsg( 'suspicious-userlogout' ) );
2121 return;
2222 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r62973Backported r62967 and r62968 to 1.16: (bug 17790) Users instantly logged off ...maxsem20:29, 25 February 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62967(bug 17790) Users instantly logged off on HughesNetmaxsem17:44, 25 February 2010

Status & tagging log