r84602 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84601‎ | r84602 | r84603 >
Date:16:30, 23 March 2011
Author:reedy
Status:ok
Tags:
Comment:
Invert match call for whitelist also

Add missing false to return documentation
Modified paths:
  • /trunk/extensions/TitleBlacklist/TitleBlacklist.list.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TitleBlacklist/TitleBlacklist.list.php
@@ -183,7 +183,7 @@
184184 }
185185 $whitelist = $this->getWhitelist();
186186 foreach( $whitelist as $item ) {
187 - if( !$item->matches( $title, $action ) ) {
 187+ if( $item->matches( $title, $action ) ) {
188188 return true;
189189 }
190190 }
@@ -305,7 +305,7 @@
306306 * @param $title Title to check
307307 * @param $action %Action to check
308308 * @return TRUE if the the regex matches the title, and is not overridden
309 - * else if it doesn't match (or was overridden)
 309+ * else false if it doesn't match (or was overridden)
310310 */
311311 public function matches( $title, $action ) {
312312 wfSuppressWarnings();

Follow-up revisions

RevisionCommit summaryAuthorDate
r846051.17wmf1: MFT r84573, r84575, r84579, r84581, r84602 (upload / blacklist fixes)catrope17:00, 23 March 2011
r85033MFT more extension revs: r82601, r82654, r82698, r82755, r82756, r82759, r829...demon18:49, 30 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84581Followup r84575, bug 27470...reedy23:07, 22 March 2011

Status & tagging log