r82698 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82697‎ | r82698 | r82699 >
Date:20:50, 23 February 2011
Author:catrope
Status:ok
Tags:
Comment:
WikiEditor: Add missing message and shut up a source of JS errors
Modified paths:
  • /trunk/extensions/WikiEditor/WikiEditor.php (modified) (history)
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/WikiEditor.php
@@ -319,6 +319,7 @@
320320 'wikieditor-toolbar-tool-link-empty',
321321 'wikieditor-toolbar-tool-file',
322322 'wikieditor-toolbar-tool-file-example',
 323+ 'wikieditor-toolbar-tool-file-pre',
323324 'wikieditor-toolbar-tool-reference',
324325 'wikieditor-toolbar-tool-reference-title',
325326 'wikieditor-toolbar-tool-reference-cancel',
Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.js
@@ -270,7 +270,9 @@
271271 }
272272 for ( var module in modules ) {
273273 // Check for the existance of an available / supported module with a matching name and a create function
274 - if ( typeof module == 'string' && $.wikiEditor.isSupported( $.wikiEditor.modules[module] ) ) {
 274+ if ( typeof module == 'string' && typeof $.wikiEditor.modules[module] !== 'undefined' &&
 275+ $.wikiEditor.isSupported( $.wikiEditor.modules[module] ) )
 276+ {
275277 // Extend the context's core API with this module's own API calls
276278 if ( 'api' in $.wikiEditor.modules[module] ) {
277279 for ( var call in $.wikiEditor.modules[module].api ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r827001.17wmf1: MFT r82698, r82699catrope21:01, 23 February 2011
r85033MFT more extension revs: r82601, r82654, r82698, r82755, r82756, r82759, r829...demon18:49, 30 March 2011

Status & tagging log