r84579 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84578‎ | r84579 | r84580 >
Date:22:49, 22 March 2011
Author:reedy
Status:ok
Tags:
Comment:
Partial revert to r83979

Reverting code in SpecialUpload, as it broke errors, leaving the other changes in place, as they are fine
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -455,8 +455,8 @@
456456 $permErrors = $this->mUpload->verifyPermissions( $wgUser );
457457 if( $permErrors !== true ) {
458458 $code = array_shift( $permErrors[0] );
459 - $this->showRecoverableUploadError( wfMsgExt( $code[0],
460 - 'parseinline', $code[1] ) );
 459+ $this->showRecoverableUploadError( wfMsgExt( $code,
 460+ 'parseinline', $permErrors[0] ) );
461461 return;
462462 }
463463

Follow-up revisions

RevisionCommit summaryAuthorDate
r846051.17wmf1: MFT r84573, r84575, r84579, r84581, r84602 (upload / blacklist fixes)catrope17:00, 23 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83979* (bug 28034) uploading file to local wiki when file exists on shared reposit...reedy23:33, 14 March 2011

Status & tagging log