r84573 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r84572‎ | r84573 | r84574 >
Date:22:22, 22 March 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r65898, fix inverse logic for title existence


Related to bug 27470 and bug 28166
Modified paths:
  • /trunk/phase3/includes/upload/UploadBase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/upload/UploadBase.php
——@@ -460,7 +460,7 @@
461461 }
462462 $permErrors = $nt->getUserPermissionsErrors( 'edit', $user );
463463 $permErrorsUpload = $nt->getUserPermissionsErrors( 'upload', $user );
464 - if ( $nt->exists() ) {
 464+ if ( !$nt->exists() ) {
465465 $permErrorsCreate = $nt->getUserPermissionsErrors( 'createpage', $user );
466466 } else {
467467 $permErrorsCreate = array();

Follow-up revisions

RevisionCommit summaryAuthorDate
r84575Followup r76344, fix another inversed logic...reedy22:30, 22 March 2011
r84577* (bug 28166) UploadBase assumes that 'edit' and 'upload' rights are not per ...reedy22:36, 22 March 2011
r84581Followup r84575, bug 27470...reedy23:07, 22 March 2011
r846051.17wmf1: MFT r84573, r84575, r84579, r84581, r84602 (upload / blacklist fixes)catrope17:00, 23 March 2011
r85435MFT: r84431, r84464, r84543, r84553, r84573, r84574, r84577, r84729, r84765, ...demon14:00, 5 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65898Fix for r65818: the proper permission is 'createpage', not 'create'. Skip che...btongminh14:48, 4 May 2010

Status & tagging log