r84577 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r84576‎ | r84577 | r84578 >
Date:22:36, 22 March 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
* (bug 28166) UploadBase assumes that 'edit' and 'upload' rights are not per page restrictions

* (bug 27470) Upload blacklist for target names not being applied

Add core bug to RELEASE-NOTES

Both fixed with r84573 and r84575

However, seems I broke some error handling in r83979, will investigate
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES
——@@ -202,6 +202,8 @@
203203 * (bug 14005) editing section 0 of an existing but empty page gives no such
204204 section error
205205 * (bug 26939) Installer does not set $wgMetaNamespace
 206+* (bug 28166) UploadBase assumes that 'edit' and 'upload' rights are not per
 207+ page restrictions
206208
207209 === API changes in 1.18 ===
208210 * (bug 26339) Throw warning when truncating an overlarge API result

Follow-up revisions

RevisionCommit summaryAuthorDate
r84581Followup r84575, bug 27470...reedy23:07, 22 March 2011
r85435MFT: r84431, r84464, r84543, r84553, r84573, r84574, r84577, r84729, r84765, ...demon14:00, 5 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83979* (bug 28034) uploading file to local wiki when file exists on shared reposit...reedy23:33, 14 March 2011
r84573Followup r65898, fix inverse logic for title existence...reedy22:22, 22 March 2011
r84575Followup r76344, fix another inversed logic...reedy22:30, 22 March 2011

Comments

#Comment by Catrope (talk | contribs)   16:14, 23 March 2011

Does this fix a regression in 1.17wmf1? Does it need to be merged to 1.17wmf1?

#Comment by Catrope (talk | contribs)   16:21, 23 March 2011

Never mind, it's just a RELEASE-NOTES change *facepalm*

Status & tagging log