r84185 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84184‎ | r84185 | r84186 >
Date:17:35, 17 March 2011
Author:ialex
Status:ok
Tags:sqliteme 
Comment:
Per Tim Starling, follow-up r83137: added schema update
Modified paths:
  • /trunk/phase3/includes/installer/MysqlUpdater.php (modified) (history)
  • /trunk/phase3/maintenance/archives/patch-user-newtalk-timestamp-null.sql (added) (history)

Diff [purge]

Index: trunk/phase3/maintenance/archives/patch-user-newtalk-timestamp-null.sql
@@ -0,0 +1 @@
 2+ALTER TABLE /*_*/user_newtalk MODIFY user_last_timestamp varbinary(14) NULL default NULL;
Property changes on: trunk/phase3/maintenance/archives/patch-user-newtalk-timestamp-null.sql
___________________________________________________________________
Added: svn:eol-style
13 + native
Index: trunk/phase3/includes/installer/MysqlUpdater.php
@@ -176,6 +176,9 @@
177177 array( 'addIndex', 'archive', 'ar_revid', 'patch-archive_ar_revid.sql' ),
178178 array( 'doLangLinksLengthUpdate' ),
179179 array( 'doClTypeVarcharUpdate' ),
 180+
 181+ // 1.18
 182+ array( 'doUserNewTalkTimestampNotNull' ),
180183 );
181184 }
182185
@@ -843,4 +846,16 @@
844847 $this->output( "...cl_type is up-to-date.\n" );
845848 }
846849 }
 850+
 851+ protected function doUserNewTalkTimestampNotNull() {
 852+ $info = $this->db->fieldInfo( 'user_newtalk', 'user_last_timestamp' );
 853+ if ( $info->isNullable() ) {
 854+ $this->output( "...user_last_timestamp is already nullable.\n" );
 855+ return;
 856+ }
 857+
 858+ $this->output( "Making user_last_timestamp nullable... " );
 859+ $this->applyPatch( 'patch-user-newtalk-timestamp-null.sql' );
 860+ $this->output( "done.\n" );
 861+ }
847862 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r84855Per CR on r84589: drop unintentially merged 1.18 schema change (r84185) and a...demon16:38, 27 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83137Fixed patch from r33520aaron06:28, 3 March 2011

Status & tagging log