r83137 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83136‎ | r83137 | r83138 >
Date:06:28, 3 March 2011
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
Fixed patch from r33520
Modified paths:
  • /trunk/phase3/maintenance/archives/patch-user_last_timestamp.sql (modified) (history)
  • /trunk/phase3/maintenance/tables.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/archives/patch-user_last_timestamp.sql
@@ -1,3 +1,3 @@
22 -- For getting diff since last view
33 ALTER TABLE /*$wgDBprefix*/user_newtalk
4 - ADD user_last_timestamp binary(14) NOT NULL default '';
 4+ ADD user_last_timestamp varbinary(14) NULL default NULL;
Index: trunk/phase3/maintenance/tables.sql
@@ -176,7 +176,7 @@
177177 user_ip varbinary(40) NOT NULL default '',
178178 -- The highest timestamp of revisions of the talk page viewed
179179 -- by this user
180 - user_last_timestamp binary(14) NOT NULL default ''
 180+ user_last_timestamp varbinary(14) NULL default NULL
181181 ) /*$wgDBTableOptions*/;
182182
183183 -- Indexes renamed for SQLite in 1.14

Follow-up revisions

RevisionCommit summaryAuthorDate
r84185Per Tim Starling, follow-up r83137: added schema updateialex17:35, 17 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r33520Add user_last_timestamp field for diff from last view links. Discussed timest...aaron21:17, 17 April 2008

Comments

#Comment by Tim Starling (talk | contribs)   09:17, 7 March 2011

Needs a schema update patch to fix the wikis which were installed from the versions where it was broken.

#Comment by Aaron Schulz (talk | contribs)   01:27, 8 March 2011

Yes, I still haven't gotten around to that yet.

Status & tagging log