r84589 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84588‎ | r84589 | r84590 >
Date:00:26, 23 March 2011
Author:demon
Status:ok (Comments)
Tags:
Comment:
MFT installer changes thru head (+db and autoloader changes from r80957)
Modified paths:
  • /branches/REL1_17/phase3/includes/AutoLoader.php (modified) (history)
  • /branches/REL1_17/phase3/includes/db (modified) (history)
  • /branches/REL1_17/phase3/includes/db/Database.php (modified) (history)
  • /branches/REL1_17/phase3/includes/db/DatabaseMysql.php (modified) (history)
  • /branches/REL1_17/phase3/includes/db/DatabaseOracle.php (modified) (history)
  • /branches/REL1_17/phase3/includes/db/LBFactory.php (modified) (history)
  • /branches/REL1_17/phase3/includes/db/LBFactory_Single.php (added) (history)
  • /branches/REL1_17/phase3/includes/db/LoadBalancer.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/CliInstaller.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/CoreInstaller.php (deleted) (history)
  • /branches/REL1_17/phase3/includes/installer/DatabaseInstaller.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/DatabaseUpdater.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/Installer.i18n.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/Installer.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/LocalSettingsGenerator.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/MysqlInstaller.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/MysqlUpdater.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/OracleInstaller.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/OracleUpdater.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/PhpBugTests.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/PostgresInstaller.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/PostgresUpdater.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/SqliteInstaller.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/SqliteUpdater.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/WebInstaller.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/WebInstallerOutput.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/WebInstallerPage.php (modified) (history)

Diff [purge]

The diff is too large to display.

Follow-up revisions

RevisionCommit summaryAuthorDate
r84855Per CR on r84589: drop unintentially merged 1.18 schema change (r84185) and a...demon16:38, 27 March 2011
r90599* (bug 29535) CC0 logo doesn't existreedy20:10, 22 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80957* Fixed a bug causing the installer to ignore the "engine" and "charset" sett...tstarling07:37, 25 January 2011
r83400(bug 17691) Support CC0 license in installerdemon20:14, 6 March 2011

Comments

#Comment by Bawolff (talk | contribs)   03:45, 26 March 2011

btw, without the autoloader entries from r82445, this commit makes update.php die with a fatal Class 'PopulateLogUsertext' not found.

#Comment by Bawolff (talk | contribs)   22:14, 26 March 2011

This also added to MysqlUpdater.php:

179 	 // 1.18
180 	array( 'doUserNewTalkTimestampNotNull' ), 

Presumably that was not supposed to be merged into REL1_17? If it was it will need the rest of r84185 (Specificly the patch file for the db changes).

(Mentioned by GreenReaper on irc).

#Comment by Catrope (talk | contribs)   19:33, 2 April 2011
+	// This is the absolute minimum PHP version we can support
+	const MINIMUM_PHP_VERSION = '5.2.3';

I don't think this requirement was supposed to go into 1.17, but I could be wrong.

#Comment by Happy-melon (talk | contribs)   19:36, 2 April 2011

AFAIR 1.17 requires 5.1.0+, and 1.18 will require 5.2.3.

Status & tagging log