r84855 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84854‎ | r84855 | r84856 >
Date:16:38, 27 March 2011
Author:demon
Status:ok
Tags:
Comment:
Per CR on r84589: drop unintentially merged 1.18 schema change (r84185) and also grap Autoloader r82445
Modified paths:
  • /branches/REL1_17/phase3/includes/AutoLoader.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/MysqlUpdater.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/installer/MysqlUpdater.php
@@ -175,9 +175,6 @@
176176 array( 'dropIndex', 'archive', 'ar_page_revid', 'patch-archive_kill_ar_page_revid.sql' ),
177177 array( 'addIndex', 'archive', 'ar_revid', 'patch-archive_ar_revid.sql' ),
178178 array( 'doLangLinksLengthUpdate' ),
179 -
180 - // 1.18
181 - array( 'doUserNewTalkTimestampNotNull' ),
182179 );
183180 }
184181
@@ -832,16 +829,4 @@
833830 $this->output( "...ll_lang is up-to-date.\n" );
834831 }
835832 }
836 -
837 - protected function doUserNewTalkTimestampNotNull() {
838 - $info = $this->db->fieldInfo( 'user_newtalk', 'user_last_timestamp' );
839 - if ( $info->isNullable() ) {
840 - $this->output( "...user_last_timestamp is already nullable.\n" );
841 - return;
842 - }
843 -
844 - $this->output( "Making user_last_timestamp nullable... " );
845 - $this->applyPatch( 'patch-user-newtalk-timestamp-null.sql' );
846 - $this->output( "done.\n" );
847 - }
848833 }
Index: branches/REL1_17/phase3/includes/AutoLoader.php
@@ -712,6 +712,7 @@
713713 'ParserTestStaticParserHook' => 'maintenance/tests/parser/parserTestsStaticParserHook.php',
714714 'PopulateCategory' => 'maintenance/populateCategory.php',
715715 'PopulateLogSearch' => 'maintenance/populateLogSearch.php',
 716+ 'PopulateLogUsertext' => 'maintenance/populateLogUsertext.php',
716717 'PopulateParentId' => 'maintenance/populateParentId.php',
717718 'PopulateRevisionLength' => 'maintenance/populateRevisionLength.php',
718719 'RemoteTestRecorder' => 'maintenance/tests/testHelpers.inc',
Property changes on: branches/REL1_17/phase3/includes/AutoLoader.php
___________________________________________________________________
Modified: svn:mergeinfo
719720 Merged /trunk/phase3/includes/AutoLoader.php:r82445

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82445Bug 27518: Updater calls PopulateLogSearch before adding logging.log_user_tex...maxsem11:49, 19 February 2011
r84185Per Tim Starling, follow-up r83137: added schema updateialex17:35, 17 March 2011
r84589MFT installer changes thru head (+db and autoloader changes from r80957)demon00:26, 23 March 2011

Status & tagging log