r84118 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84117‎ | r84118 | r84119 >
Date:18:23, 16 March 2011
Author:bawolff
Status:ok (Comments)
Tags:
Comment:
(follow-up r65035/r65013) The username parameter wasn't preserved when clicking links in Special:Listfiles.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialListfiles.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialListfiles.php
@@ -238,9 +238,19 @@
239239 if ( !is_null( $this->mUserName ) ) {
240240 # Append the username to the query string
241241 foreach ( $queries as &$query ) {
242 - $query['username'] = $this->mUserName;
 242+ $query['user'] = $this->mUserName;
243243 }
244244 }
245245 return $queries;
246246 }
 247+
 248+ function getDefaultQuery() {
 249+ $queries = parent::getDefaultQuery();
 250+ if ( !isset( $queries['user'] )
 251+ && !is_null( $this->mUserName ) )
 252+ {
 253+ $queries['user'] = $this->mUserName;
 254+ }
 255+ return $queries;
 256+ }
247257 }
Index: trunk/phase3/RELEASE-NOTES
@@ -193,6 +193,7 @@
194194 for "ABORTED" reason to be returned and displayed to user.
195195 * (bug 28034) uploading file to local wiki when file exists on shared repository
196196 (commons) gives spurious info in the warning message
 197+* Usernames get lost when selecting different sorts on Special:listfiles
197198
198199 === API changes in 1.18 ===
199200 * (bug 26339) Throw warning when truncating an overlarge API result

Follow-up revisions

RevisionCommit summaryAuthorDate
r844201.17wmf1: MFT r76372, r76377, r83586, r83587, r83817, r83876, r83979, r84118,...catrope21:04, 20 March 2011
r85434MFT: r83885, r83891, r83897, r83902, r83903, r83934, r83965, r83979, r83988, ...demon13:38, 5 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65013Special:Listfiles now supports a username parameter. This is indexed using th...btongminh09:03, 14 April 2010
r65035Follow-up to r65013: Preserve username when clicking navigation links.btongminh16:15, 14 April 2010

Comments

#Comment by Bawolff (talk | contribs)   18:23, 16 March 2011

I'm tagging this 1.17, but i'm not sure if it counts since its such a minor thing.

Status & tagging log