r76372 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76371‎ | r76372 | r76373 >
Date:03:49, 9 November 2010
Author:werdna
Status:resolved (Comments)
Tags:
Comment:
Bug 23716: Fix Rollback and Mark Patrolled on LiquidThreads *comments*. Patch by Nx.devnull
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/Dispatch.php (modified) (history)
  • /trunk/extensions/LiquidThreads/classes/Hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/Dispatch.php
@@ -73,7 +73,7 @@
7474 $viewname = 'ThreadHistoricalRevisionView';
7575 } else if ( $action == 'watch' || $action == 'unwatch' ) {
7676 $viewname = 'ThreadWatchView';
77 - } elseif ( $action == 'delete' ) {
 77+ } elseif ( $action == 'delete' || $action = 'rollback' || $action = 'markpatrolled' ) {
7878 return true;
7979 } else {
8080 $viewname = 'ThreadPermalinkView';
Index: trunk/extensions/LiquidThreads/classes/Hooks.php
@@ -445,16 +445,13 @@
446446 return true;
447447 }
448448
449 - LqtView::postEditUpdates(
450 - 'editExisting',
451 - null,
452 - $article,
453 - $thread->article(),
454 - $thread->article(),
455 - $summary,
456 - $thread,
457 - $text
458 - );
 449+ LqtView::editMetadataUpdates(
 450+ array(
 451+ 'root' => $article,
 452+ 'thread' => $thread,
 453+ 'summary' => $summary,
 454+ 'text' => $text,
 455+ ) );
459456
460457 return true;
461458 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r76377Fix bug in r76372 (== versus =)werdna05:08, 9 November 2010
r844201.17wmf1: MFT r76372, r76377, r83586, r83587, r83817, r83876, r83979, r84118,...catrope21:04, 20 March 2011

Comments

#Comment by Hashar (talk | contribs)   07:24, 15 March 2011

+1.17wmf1 per comment on bug 23716

MAKE SURE TO MERGE r73377 TOO!

Status & tagging log