r83903 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83902‎ | r83903 | r83904 >
Date:15:16, 14 March 2011
Author:catrope
Status:ok
Tags:
Comment:
(bug 27564) Timestamp of site module embedded in Squid-cached page HTML
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -2505,10 +2505,12 @@
25062506 }
25072507 continue;
25082508 }
2509 - // Special handling for user and site groups; because users might change their stuff
2510 - // on-wiki like site or user pages, or user preferences; we need to find the highest
 2509+ // Special handling for the user group; because users might change their stuff
 2510+ // on-wiki like user pages, or user preferences; we need to find the highest
25112511 // timestamp of these user-changable modules so we can ensure cache misses on change
2512 - if ( $group === 'user' || $group === 'site' ) {
 2512+ // This should NOT be done for the site group (bug 27564) because anons get that too
 2513+ // and we shouldn't be putting timestamps in Squid-cached HTML
 2514+ if ( $group === 'user' ) {
25132515 // Get the maximum timestamp
25142516 $timestamp = 1;
25152517 foreach ( $modules as $module ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r846131.17wmf1: MFT r81692, r82468, r83814, r83885, r83891, r83897, r83902, r83903,...catrope17:42, 23 March 2011
r85434MFT: r83885, r83891, r83897, r83902, r83903, r83934, r83965, r83979, r83988, ...demon13:38, 5 April 2011

Status & tagging log