r83897 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r83896‎ \| r83897 \| r83898 >
Date:	14:25, 14 March 2011
Author:	catrope
Status:	ok
Tags:
Comment:	(bug 27054) Implicit end of statement can break stuff when files are combined. Applied patch by Paul Copperman: add a semicolon to the end of every module when combining; this'll terminate any unterminated final statement, and otherwise create a harmless empty statement.
Modified paths:	/trunk/phase3/includes/resourceloader/ResourceLoader.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/resourceloader/ResourceLoader.php
—	—	@@ -468,7 +468,9 @@
469	469	// Scripts
470	470	$scripts = '';
471	471	if ( $context->shouldIncludeScripts() ) {
472		~~- $scripts .= $module->getScript( $context ) . "\n";~~
	472	+ // bug 27054: Append semicolon to prevent weird bugs
	473	+ // caused by files not terminating their statements right
	474	+ $scripts .= $module->getScript( $context ) . ";\n";
473	475	}
474	476
475	477	// Styles

Revision	Commit summary	Author	Date
r84613	1.17wmf1: MFT r81692, r82468, r83814, r83885, r83891, r83897, r83902, r83903,...	catrope	17:42, 23 March 2011
r85434	MFT: r83885, r83891, r83897, r83902, r83903, r83934, r83965, r83979, r83988, ...	demon	13:38, 5 April 2011

Revision	Commit summary	Author	Date
r81228	SVGEdit extension UI prettification, fixes....	brion	03:46, 31 January 2011

13:39, 5 April 2011 😂 (talk | contribs) changed the tags for r83897 [removed: 1.17]
19:15, 23 March 2011 Catrope (talk | contribs) changed the tags for r83897 [removed: 1.17wmf1]
15:34, 22 March 2011 Trevor Parscal (WMF) (talk | contribs) changed the tags for r83897 [removed: trevor]
15:32, 22 March 2011 Trevor Parscal (WMF) (talk | contribs) changed the status of r83897 [removed: new added: ok]
15:19, 14 March 2011 Catrope (talk | contribs) changed the tags for r83897 [added: 1.17,1.17wmf1]
15:18, 14 March 2011 Catrope (talk | contribs) changed the tags for r83897 [added: trevor]