r82458 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82457‎ | r82458 | r82459 >
Date:15:02, 19 February 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
(bug 27502) Monospace text too small
Modified paths:
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.css (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.css
——@@ -241,7 +241,7 @@
242242 }
243243 .wikiEditor-ui-toolbar .section-help .page-table td.cell-syntax,
244244 .wikiEditor-ui-toolbar .section-help .page-table td.syntax {
245 - font-family: monospace;
 245+ font-family: monospace, "Courier New";
246246 }
247247 .wikiEditor-ui-toolbar .section-help .page-table td.syntax,
248248 .wikiEditor-ui-toolbar .section-help .page-table td.cell-syntax,
——@@ -267,7 +267,7 @@
268268 color: black;
269269 text-decoration: none;
270270 cursor: pointer;
271 - font-family: monospace;
 271+ font-family: monospace, "Courier New";
272272 font-size: 1.25em;
273273 }
274274 .wikiEditor-ui-toolbar .page-characters div[dir=rtl] span {

Follow-up revisions

RevisionCommit summaryAuthorDate
r825331.17wmf1: MFT r78893, r78897, r78909, r82404, r82408, r82409, r82453, r82456,...catrope20:13, 20 February 2011
r85027MFT various extension fixes: r81713, r81742, r81743, r81908, r81966, r81969, ...demon18:23, 30 March 2011

Comments

#Comment by Trevor Parscal (WMF) (talk | contribs)   18:26, 22 February 2011

Well played - this is similar to r69336, and equally effective.

#Comment by Catrope (talk | contribs)   18:41, 22 February 2011

I really just did what the guy on the bug report said. He also suggested I remove the font-size rule below, but I wanted to run that by you before I did it. Could you look at that?

#Comment by Trevor Parscal (WMF) (talk | contribs)   19:00, 22 February 2011

I don't think that size was placed there as a fix to a font-size bug, it's part of the visual design. Now that the font size is normalized, if we want to change the design, that's probably an entirely different bug. I'm personally in favor of keeping it.

Status & tagging log