r82133 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82132‎ | r82133 | r82134 >
Date:20:09, 14 February 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: MFT r82132. Merging this first because the same change is present as a local change on the cluster
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/CodeReview/backend/CodeRevision.php
@@ -437,14 +437,14 @@
438438 }
439439
440440 /**
441 - * @param $subject
442 - * @param $body
 441+ * @param $subject String
 442+ * @param $body String
443443 * @return void
444444 */
445445 public function emailNotifyUsersOfChanges( $subject, $body ) {
446446 // Give email notices to committer and commenters
447447 global $wgCodeReviewENotif, $wgEnableEmail, $wgCodeReviewCommentWatcherEmail,
448 - $wgCodeReviewCommentWatcherName, $wgUser;
 448+ $wgCodeReviewCommentWatcherName;
449449 if ( !$wgCodeReviewENotif || !$wgEnableEmail ) {
450450 return;
451451 }
@@ -475,7 +475,7 @@
476476 $lang = array( 'language' => $user->getOption( 'language' ) );
477477
478478 $localSubject = wfMsgExt( $subject, $lang, $this->mRepo->getName(), $this->getIdString() );
479 - $localBody = call_user_func_array( 'wfMsgExt', array_merge( array( $body, $lang, $wgUser->getName() ), $args ) );
 479+ $localBody = call_user_func_array( 'wfMsgExt', array_merge( array( $body, $lang ), $args ) );
480480
481481 $user->sendMail( $localSubject, $localBody );
482482 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82132Fixup hard coding usage of $wgUser->getName() in CodeRevision::emailNotifyUse...reedy19:58, 14 February 2011

Status & tagging log