r82101 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82100‎ | r82101 | r82102 >
Date:01:45, 14 February 2011
Author:brion
Status:ok
Tags:
Comment:
* (bug 23320) Fix CentralAuth method popup on Vector skin

Patch by Derk-Jan Hartman, posted April 2010 on https://bugzilla.wikimedia.org/show_bug.cgi?id=23320
Have not tested in a local install but it looks fine -- please test on prototype etc.
Modified paths:
  • /trunk/extensions/CentralAuth/centralauth.js (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/centralauth.js
@@ -21,7 +21,9 @@
2222 methodHint.style.left = wgCursorPosition.x + 'px';
2323 methodHint.style.top = wgCursorPosition.y + 'px';
2424 methodHint.setAttribute( 'onclick', 'hideMethodHint()' );
25 - document.getElementById( 'globalWrapper' ).appendChild( methodHint );
 25+
 26+ var content = document.getElementById('content') || document.getElementById('mw_content') || document.body;
 27+ content.appendChild( methodHint );
2628 }
2729
2830 function hideMethodHint() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r821511.17wmf1: MFT r78964, r79086, r79087, r79091, r82004, r82025, r82048, r82070,...catrope22:55, 14 February 2011
r85027MFT various extension fixes: r81713, r81742, r81743, r81908, r81966, r81969, ...demon18:23, 30 March 2011

Status & tagging log