r81105 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r81104‎ \| r81105 \| r81106 >
Date:	21:14, 27 January 2011
Author:	hashar
Status:	ok (Comments)
Tags:
Comment:	invalid 'var' in JS email validation follow up r81101
Modified paths:	/trunk/phase3/resources/mediawiki.util/mediawiki.util.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.util/mediawiki.util.js
—	—	@@ -486,7 +486,7 @@
487	487	* <let-dig-hyp> ::= <let-dig> \| "-"
488	488	* <let-dig> ::= <letter> \| <digit>
489	489	*/
490		~~- var rfc1034_ldh_str = "a-z0-9\\-",~~
	490	+ rfc1034_ldh_str = "a-z0-9\\-",
491	491
492	492	HTML5_email_regexp = new RegExp(
493	493	// start of string

Follow-up revisions

Revision	Commit summary	Author	Date
r81402	1.17: MFT r79915, r79957, r79964, r79990, r80687, r80999, r81006, r81011, r81...	catrope	16:18, 2 February 2011

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r81101	Bug 26948 - hyphens incorrectly interpreted as range...	hashar	20:52, 27 January 2011

Comments

#Comment by Hashar (talk | contribs) 21:46, 27 January 2011

marking 1.17 since it fixes r81101 (javascript error)

Status & tagging log

16:19, 2 February 2011 Catrope (talk | contribs) changed the tags for r81105 [removed: 1.17]
23:44, 27 January 2011 Catrope (talk | contribs) changed the status of r81105 [removed: new added: ok]
21:46, 27 January 2011 Hashar (talk | contribs) changed the tags for r81105 [added: 1.17]