r79915 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79914‎ | r79915 | r79916 >
Date:20:30, 9 January 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
Correct {,in}valid js messages in UserPreferences
Add them to messages.inc

Thanks Roan and ^demon for the translation.

FU r79904
Modified paths:
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1030,6 +1030,8 @@
10311031 'prefs-displaysearchoptions',
10321032 'prefs-displaywatchlist',
10331033 'prefs-diffs',
 1034+ 'email-address-validity-valid',
 1035+ 'email-address-validity-invalid',
10341036 ),
10351037 'userrights' => array(
10361038 'userrights',
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1858,8 +1858,8 @@
18591859 'prefs-diffs' => 'Diffs',
18601860
18611861 # User preference: email validation using JQuery
1862 -'email-address-validity-valid' => 'Looks valid',
1863 -'email-address-validity-invalid' => 'Valid address required!',
 1862+'email-address-validity-valid' => 'E-mail address appears valid',
 1863+'email-address-validity-invalid' => 'Enter a valid e-mail address',
18641864
18651865 # User rights
18661866 'userrights' => 'User rights management',

Follow-up revisions

RevisionCommit summaryAuthorDate
r79957Follow-up r79915: Add new section in maintenance file tooraymond20:54, 10 January 2011
r814021.17: MFT r79915, r79957, r79964, r79990, r80687, r80999, r81006, r81011, r81...catrope16:18, 2 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79904js email validation fixed + i18n support...hashar17:09, 9 January 2011

Comments

#Comment by Bawolff (talk | contribs)   05:46, 1 February 2011

Tagging 1.17. Looks like r79924 which was merged into 1.17 requires this revision. See bug 27085

Status & tagging log