r79990 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79989‎ | r79990 | r79991 >
Date:07:37, 11 January 2011
Author:raymond
Status:ok
Tags:
Comment:
Follow-up r79964: Use the existing message 'parentheses' instead of introducing an identical one.
Modified paths:
  • /trunk/phase3/includes/ImagePage.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesQqq.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -2560,7 +2560,6 @@
25612561 'widthheightpage',
25622562 'file-info',
25632563 'file-info-size',
2564 - 'file-info-wrapper',
25652564 'file-nohires',
25662565 'svg-long-desc',
25672566 'show-big-image',
Index: trunk/phase3/includes/ImagePage.php
@@ -330,7 +330,7 @@
331331 $height_orig = $this->displayImg->getHeight( $page );
332332 $height = $height_orig;
333333
334 - $longDesc = wfMsgExt( 'file-info-wrapper', 'parseinline', $this->displayImg->getLongDesc() );
 334+ $longDesc = wfMsgExt( 'parentheses', 'parseinline', $this->displayImg->getLongDesc() );
335335
336336 wfRunHooks( 'ImageOpenShowImageInlineBefore', array( &$this, &$wgOut ) );
337337
Index: trunk/phase3/includes/specials/SpecialSearch.php
@@ -594,7 +594,7 @@
595595 if( $img ) {
596596 $thumb = $img->transform( array( 'width' => 120, 'height' => 120 ) );
597597 if( $thumb ) {
598 - $desc = wfMsgExt( 'file-info-wrapper', 'parseinline', $img->getShortDesc() );
 598+ $desc = wfMsgExt( 'parentheses', 'parseinline', $img->getShortDesc() );
599599 wfProfileOut( __METHOD__ );
600600 // Float doesn't seem to interact well with the bullets.
601601 // Table messes up vertical alignment of the bullets.
Index: trunk/phase3/languages/messages/MessagesQqq.php
@@ -3059,7 +3059,6 @@
30603060 'widthheightpage' => 'This message is used on image pages in the dimensions column in the file history section for images with more than one page. Parameter $1 is the image width (in pixels), parameter $2 is the image height, and parameter $3 is the number of pages.',
30613061 'file-info' => 'File info displayed on file description page.',
30623062 'file-info-size' => 'File info displayed on file description page.',
3063 -'file-info-wrapper' => 'Surrounds file info descriptions',
30643063 'file-nohires' => 'File info displayed on file description page. For example of message in use see [[:File:Mouse10.gif]].',
30653064 'svg-long-desc' => 'Displayed under an SVG image at the image description page. Note that argument 3 is a string that includes the file size unit symbol. See for example [[:File:Yes check.svg]].',
30663065 'show-big-image' => 'Displayed under an image at the image description page, when it is displayed smaller there than it was uploaded.',
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -3604,7 +3604,6 @@
36053605 'widthheightpage' => '$1×$2, $3 {{PLURAL:$3|page|pages}}',
36063606 'file-info' => 'file size: $1, MIME type: $2',
36073607 'file-info-size' => '$1 × $2 pixels, file size: $3, MIME type: $4',
3608 -'file-info-wrapper' => '($1)',
36093608 'file-nohires' => '<small>No higher resolution available.</small>',
36103609 'svg-long-desc' => 'SVG file, nominally $1 × $2 pixels, file size: $3',
36113610 'show-big-image' => 'Full resolution',

Follow-up revisions

RevisionCommit summaryAuthorDate
r814021.17: MFT r79915, r79957, r79964, r79990, r80687, r80999, r81006, r81011, r81...catrope16:18, 2 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79964Move the () surrounding description strings of files, out of the description ...hartman22:18, 10 January 2011

Status & tagging log