r81006 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r81005‎ | r81006 | r81007 >
Date:23:37, 25 January 2011
Author:platonides
Status:ok
Tags:
Comment:
generateUpgradeKey() could produce NULL return, which means a fatal error when
Call to a member function isOk() in includes/installer/WebInstallerPage.php on line 1039
Modified paths:
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/Installer.php
——@@ -1352,6 +1352,7 @@
13531353 if ( strval( $this->getVar( 'wgUpgradeKey' ) ) === '' ) {
13541354 return $this->generateSecret( 'wgUpgradeKey', 16 );
13551355 }
 1356+ return Status::newGood();
13561357 }
13571358
13581359 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r814021.17: MFT r79915, r79957, r79964, r79990, r80687, r80999, r81006, r81011, r81...catrope16:18, 2 February 2011

Status & tagging log