r81052 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81051‎ | r81052 | r81053 >
Date:21:50, 26 January 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Revert most of r80948 - some of these changes will be re-applied in different ways in the next revision.
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images.psd (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/alert.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/form-hover.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/form.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/question-hover.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/question.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/report-hover.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/report.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/segment-cap.png (deleted) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/segment-empty.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/segment-full.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-empty.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-full-hover.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-full.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-new-down.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-new-hover.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-new.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/trash-hover.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/trash.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.css (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/segment-cap.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/report-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/segment-empty.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-new.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/trash-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/segment-full.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/form.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-empty.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-new-down.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/alert.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/question.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-full.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/report.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/trash.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-new-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/form-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/question-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-full-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images.psd
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.css
@@ -172,7 +172,7 @@
173173 float: left;
174174 height: 17px;
175175 width: 101px;
176 - border: none;
 176+ border: solid 1px #cccccc;
177177 border-radius: 3px;
178178 /* @embed */
179179 background-image: url(images/segment-empty.png);
@@ -191,8 +191,7 @@
192192 }
193193
194194 .articleFeedback-rating-count {
195 - float: left;
196 - margin-left: 2.5em;
 195+ float: right;
197196 font-size: 0.8em;
198197 color: #999999;
199198 cursor: default;

Follow-up revisions

RevisionCommit summaryAuthorDate
r81063Finishes what r81052 started, re-applying most of the intention of r80948, on...tparscal23:04, 26 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80948* Updated graphics to conform with design, both in the psd and cut images...bharris00:46, 25 January 2011

Status & tagging log