r80948 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80947‎ | r80948 | r80949 >
Date:00:46, 25 January 2011
Author:bharris
Status:resolved (Comments)
Tags:
Comment:
* Updated graphics to conform with design, both in the psd and cut images
* Added in new slice and graphic, segment-cap.png
- Requires slight reworking by Trevor to handle the background issues on the thermometers. I'd do it myself but he's a bazillion times better than me at this.
* Modified the language for some elements in the i18n file
* Added new keys surrounding the addition of "expert self-identification"
* Removed border from thermometer css
* Left aligned rating count and added some margins
Modified paths:
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images.psd (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/alert.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/form-hover.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/form.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/question-hover.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/question.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/report-hover.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/report.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/segment-cap.png (added) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/segment-empty.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/segment-full.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-empty.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-full-hover.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-full.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-new-down.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-new-hover.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-new.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/trash-hover.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/trash.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.css (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/report-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/segment-empty.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-new.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/trash-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/segment-full.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/form.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/segment-cap.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/segment-cap.png
___________________________________________________________________
Added: svn:mime-type
11 + application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-empty.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-new-down.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/alert.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/question.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-full.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/report.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/trash.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-new-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/form-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/question-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-full-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images.psd
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.css
@@ -172,7 +172,7 @@
173173 float: left;
174174 height: 17px;
175175 width: 101px;
176 - border: solid 1px #cccccc;
 176+ border: none;
177177 border-radius: 3px;
178178 /* @embed */
179179 background-image: url(images/segment-empty.png);
@@ -191,7 +191,8 @@
192192 }
193193
194194 .articleFeedback-rating-count {
195 - float: right;
 195+ float: left;
 196+ margin-left: 2.5em;
196197 font-size: 0.8em;
197198 color: #999999;
198199 cursor: default;
Index: trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php
@@ -27,12 +27,12 @@
2828 'articlefeedback-survey-title' => 'Please answer a few questions',
2929 'articlefeedback-survey-thanks' => 'Thanks for filling out the survey.',
3030 /* Beta Messages */
31 - 'articlefeedback-form-switch-label' => 'Provide feedback',
32 - 'articlefeedback-form-panel-title' => 'Your feedback',
 31+ 'articlefeedback-form-switch-label' => 'Rate this page',
 32+ 'articlefeedback-form-panel-title' => 'Rate this Page',
3333 'articlefeedback-form-panel-instructions' => 'Please take a moment to rate this page.',
3434 'articlefeedback-form-panel-submit' => 'Submit feedback',
35 - 'articlefeedback-report-switch-label' => 'Show results',
36 - 'articlefeedback-report-panel-title' => 'Feedback results',
 35+ 'articlefeedback-report-switch-label' => 'View Page Ratings',
 36+ 'articlefeedback-report-panel-title' => 'Page ratings',
3737 'articlefeedback-report-panel-description' => 'Current average ratings.',
3838 'articlefeedback-report-empty' => 'No ratings',
3939 'articlefeedback-report-ratings' => '$1 ratings',
@@ -54,6 +54,11 @@
5555 'articlefeedback-pitch-makefirstedit-title' => 'Would you like to edit this page?',
5656 'articlefeedback-pitch-makefirstedit-message' => '-- message --',
5757 'articlefeedback-pitch-makefirstedit-accept' => 'Start editing',
 58+ 'articlefeedback-expert-assessment-question' => 'Do you have knowledge in this topic?',
 59+ 'articlefeedback-expert-assessment-level-1-label' => 'Marginal',
 60+ 'articlefeedback-expert-assessment-level-2-label' => 'Competent',
 61+ 'articlefeedback-expert-assessment-level-3-label' => 'Expert',
 62+
5863 );
5964
6065 /** Message documentation (Message documentation)
@@ -84,6 +89,12 @@
8590 {{Identical|Submit}}',
8691 'articlefeedback-survey-title' => 'This text appears in the title bar of the survey dialog.',
8792 'articlefeedback-survey-thanks' => 'This text appears when the user has successfully submitted the survey.',
 93+
 94+ 'articlefeedback-expert-assessment-question' => 'This question asks the user to self-identify as a subject matter expert',
 95+ 'articlefeedback-expert-assessment-level-1-label' => 'This is a term that indicates some degree of knowledge in the subject',
 96+ 'articlefeedback-expert-assessment-level-2-label' => 'This is a term that indicates an average level of knowledge in the subject',
 97+ 'articlefeedback-expert-assessment-level-3-label' => 'This is a term that indicates an above-average, expert level of knowledge in the subject',
 98+
8899 );
89100
90101 /** Afrikaans (Afrikaans)

Follow-up revisions

RevisionCommit summaryAuthorDate
r81052Revert most of r80948 - some of these changes will be re-applied in different...tparscal21:50, 26 January 2011
r81063Finishes what r81052 started, re-applying most of the intention of r80948, on...tparscal23:04, 26 January 2011

Comments

#Comment by Trevor Parscal (WMF) (talk | contribs)   21:51, 26 January 2011

Most of these changes are going to be re-applied in a different way.

Status & tagging log