r81051 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81050‎ | r81051 | r81052 >
Date:21:24, 26 January 2011
Author:foxtrott
Status:deferred
Tags:
Comment:
floating form now gets (max z-index) + 1 to put it above all other elements
Modified paths:
  • /trunk/extensions/SemanticForms/libs/SF_popupform.js (modified) (history)
  • /trunk/extensions/SemanticForms/skins/SF_popupform.css (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/skins/SF_popupform.css
@@ -20,7 +20,6 @@
2121 height: 100%;
2222 width: 100%;
2323 background: black;
24 - z-index: 4;
2524
2625 }
2726
@@ -30,7 +29,6 @@
3130 top: 50%;
3231 width: 0;
3332 height: 0;
34 - z-index: 6;
3533 }
3634
3735 div.popupform-container {
@@ -59,7 +57,6 @@
6058 position: fixed;
6159 left: 50%;
6260 top: 50%;
63 - z-index: 5;
6461 }
6562
6663 div.popupform-loadingbg {
Index: trunk/extensions/SemanticForms/libs/SF_popupform.js
@@ -135,6 +135,14 @@
136136
137137 brokenBrowser= jQuery.browser.msie ||brokenChrome;
138138
 139+ var maxZIndex = 0;
 140+
 141+ jQuery("*").each(function() {
 142+ var curr = parseInt( jQuery( this ).css( "z-index" ) );
 143+ maxZIndex = curr > maxZIndex ? curr : maxZIndex;
 144+ });
 145+
 146+
139147 wrapper = jQuery( "<div class='popupform-wrapper' >" );
140148 background = jQuery( "<div class='popupform-background' >" );
141149
@@ -168,6 +176,7 @@
169177 .append(container);
170178
171179 wrapper
 180+ .css( "z-index", maxZIndex + 1 )
172181 .append( background )
173182 .append( waitIndicatorWrapper )
174183 .append( anchor )