r81063 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81062‎ | r81063 | r81064 >
Date:23:04, 26 January 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Finishes what r81052 started, re-applying most of the intention of r80948, only in slightly different ways.
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images.psd (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/segment-empty.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/segment-full.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-empty.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-full-hover.png (deleted) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-full.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-new-down.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-new-hover.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-new.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.css (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
@@ -307,13 +307,15 @@
308308 .hover(
309309 function() {
310310 $(this)
311 - .addClass( 'articleFeedback-rating-label-hover' )
 311+ .addClass( 'articleFeedback-rating-label-hover-head' )
312312 .prevAll( 'label' )
313 - .andSelf()
314 - .addClass( 'articleFeedback-rating-label-full' );
 313+ .addClass( 'articleFeedback-rating-label-hover-tail' );
315314 },
316315 function() {
317 - $(this).removeClass( 'articleFeedback-rating-label-hover' );
 316+ $(this)
 317+ .removeClass( 'articleFeedback-rating-label-hover-head' )
 318+ .prevAll( 'label' )
 319+ .removeClass( 'articleFeedback-rating-label-hover-tail' );
318320 $.articleFeedback.fn.updateRating.call(
319321 $(this).closest( '.articleFeedback-rating' )
320322 );
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-full-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/segment-empty.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-new.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/segment-full.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-empty.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-new-down.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-full.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images/star-new-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/images.psd
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.css
@@ -132,17 +132,13 @@
133133 background-image: url(images/star-full.png);
134134 }
135135
136 -.articleFeedback-rating-labels label.articleFeedback-rating-label-hover {
 136+.articleFeedback-rating-new .articleFeedback-rating-labels label.articleFeedback-rating-label-full,
 137+.articleFeedback-rating .articleFeedback-rating-labels label.articleFeedback-rating-label-hover-tail {
137138 /* @embed */
138 - background-image: url(images/star-full-hover.png);
139 -}
140 -
141 -.articleFeedback-rating-new .articleFeedback-rating-labels label.articleFeedback-rating-label-full {
142 - /* @embed */
143139 background-image: url(images/star-new.png);
144140 }
145141
146 -.articleFeedback-rating-new .articleFeedback-rating-labels label.articleFeedback-rating-label-hover {
 142+.articleFeedback-rating .articleFeedback-rating-labels label.articleFeedback-rating-label-hover-head {
147143 /* @embed */
148144 background-image: url(images/star-new-hover.png);
149145 }
@@ -171,7 +167,7 @@
172168 .articleFeedback-rating-meter {
173169 float: left;
174170 height: 17px;
175 - width: 101px;
 171+ width: 104px;
176172 border: solid 1px #cccccc;
177173 border-radius: 3px;
178174 /* @embed */
@@ -183,7 +179,6 @@
184180 .articleFeedback-rating-meter div {
185181 float: left;
186182 height: 17px;
187 - margin-left: 1px;
188183 /* @embed */
189184 background-image: url(images/segment-full.png);
190185 background-repeat: repeat-x;

Follow-up revisions

RevisionCommit summaryAuthorDate
r81064Updated PSD for changes made in r81063tparscal23:05, 26 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80948* Updated graphics to conform with design, both in the psd and cut images...bharris00:46, 25 January 2011
r81052Revert most of r80948 - some of these changes will be re-applied in different...tparscal21:50, 26 January 2011

Status & tagging log