r80773 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80772‎ | r80773 | r80774 >
Date:22:21, 22 January 2011
Author:hartman
Status:resolved (Comments)
Tags:
Comment:
Remove RTL definitions from skins/common/shared.css

With the new auto rtl flipping of resourceloader, all rtl sites were broken.
Modified paths:
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -104,12 +104,9 @@
105105 /**
106106 * Forms
107107 */
108 -body.ltr td.mw-label { text-align: right; }
109 -body.ltr td.mw-input { text-align: left; }
110 -body.ltr td.mw-submit { text-align: left; }
111 -body.rtl td.mw-label { text-align: left; }
112 -body.rtl td.mw-input { text-align: right; }
113 -body.rtl td.mw-submit { text-align: right; }
 108+td.mw-label { text-align: right; }
 109+td.mw-input { text-align: left; }
 110+td.mw-submit { text-align: left; }
114111
115112 td.mw-label { vertical-align: top; }
116113 .prefsection td.mw-label { width: 20%; }
@@ -131,12 +128,9 @@
132129 /**
133130 * Image captions
134131 */
135 -body.rtl .thumbcaption { text-align: right; }
136 -body.rtl .magnify { float: left; }
 132+.thumbcaption { text-align: right; }
 133+.magnify { float: left; }
137134
138 -body.ltr .thumbcaption { text-align: left; }
139 -body.ltr .magnify { float: right; }
140 -
141135 /**
142136 * Hidden categories
143137 */
@@ -193,9 +187,6 @@
194188 float: left;
195189 padding-left: 0.25em;
196190 }
197 -.rtl .mw-search-formheader div.search-types {
198 - float: right;
199 -}
200191 .mw-search-formheader div.search-types ul {
201192 margin: 0 !important;
202193 padding: 0 !important;
@@ -251,15 +242,9 @@
252243 margin: 0;
253244 float: left;
254245 }
255 -.rtl fieldset#mw-searchoptions h4 {
256 - float: right;
257 -}
258246 fieldset#mw-searchoptions div#mw-search-togglebox {
259247 float: right;
260248 }
261 -.rtl fieldset#mw-searchoptions div#mw-search-togglebox {
262 - float: left;
263 -}
264249
265250 fieldset#mw-searchoptions div#mw-search-togglebox label {
266251 margin-right: 0.25em;
@@ -274,15 +259,6 @@
275260 fieldset#mw-searchoptions table td {
276261 padding-right: 1em;
277262 }
278 -.rtl fieldset#mw-searchoptions table td {
279 - padding-left: 1em;
280 - padding-right: 0;
281 -}
282 -body.rtl fieldset#mw-searchoptions table {
283 - margin-right: 0;
284 - margin-left: 3em;
285 - float: right;
286 -}
287263 fieldset#mw-searchoptions div.divider {
288264 clear: both;
289265 border-bottom: 1px solid #DDDDDD;
@@ -304,10 +280,6 @@
305281 margin-top: 2ex;
306282 }
307283
308 -.rtl div#mw-search-interwiki {
309 - float: left;
310 -}
311 -
312284 div#mw-search-interwiki li {
313285 font-size: 95%;
314286 }
@@ -317,10 +289,6 @@
318290 font-size: 90%;
319291 }
320292
321 -.rtl .mw-search-interwiki-more {
322 - float: left;
323 -}
324 -
325293 div#mw-search-interwiki-caption {
326294 text-align: center;
327295 font-weight: bold;
@@ -338,10 +306,6 @@
339307 border-top: 1px solid #BBBBBB;
340308 }
341309
342 -.rtl .mw-search-interwiki-project {
343 - text-align: right;
344 -}
345 -
346310 span.searchalttitle {
347311 font-size: 95%;
348312 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r80774Follow up to r80773. Repair the thumbcaptions alignment.hartman22:29, 22 January 2011
r808971.17: MFT r80697, r80755, r80767, r80771, r80773, r80774, r80779, r80816, r80...catrope18:57, 24 January 2011

Comments

#Comment by Krinkle (talk | contribs)   22:24, 22 January 2011
-body.rtl .thumbcaption { text-align: right; }
-body.rtl .magnify { float: left; }
+.thumbcaption { text-align: right; }
+.magnify { float: left; }
 
-body.ltr .thumbcaption { text-align: left; }
-body.ltr .magnify { float: right; }

I could be missing something, but that doesn't seem right to me. the default should be the "ltr" value, right ?

Status & tagging log