r80772 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80771‎ | r80772 | r80773 >
Date:21:29, 22 January 2011
Author:hartman
Status:ok (Comments)
Tags:
Comment:
Port Chick to Resourceloader. Bug 26649
Modified paths:
  • /trunk/phase3/resources/Resources.php (modified) (history)
  • /trunk/phase3/resources/jquery/jquery.placeholder.js (modified) (history)
  • /trunk/phase3/skins/Chick.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Chick.php
@@ -23,10 +23,12 @@
2424
2525 function setupSkinUserCss( OutputPage $out ){
2626 parent::setupSkinUserCss( $out );
27 - // Append to the default screen common & print styles...
28 - $out->addStyle( 'chick/main.css', 'screen,handheld' );
29 - $out->addStyle( 'chick/IE50Fixes.css', 'screen,handheld', 'lt IE 5.5000' );
30 - $out->addStyle( 'chick/IE55Fixes.css', 'screen,handheld', 'IE 5.5000' );
31 - $out->addStyle( 'chick/IE60Fixes.css', 'screen,handheld', 'IE 6' );
 27+
 28+ $out->addModuleStyles( 'skins.chick' );
 29+
 30+ // TODO: Migrate all of these
 31+ //$out->addStyle( 'chick/IE50Fixes.css', 'screen,handheld', 'lt IE 5.5000' );
 32+ //$out->addStyle( 'chick/IE55Fixes.css', 'screen,handheld', 'IE 5.5000' );
 33+ //$out->addStyle( 'chick/IE60Fixes.css', 'screen,handheld', 'IE 6' );
3234 }
3335 }
Index: trunk/phase3/resources/jquery/jquery.placeholder.js
@@ -38,7 +38,7 @@
3939 } )
4040
4141 // Hide on focus
42 - .focus( function() {
 42+ .bind( 'onfocus ondrop ondragdrop', function() {
4343 if ($input.hasClass('placeholder')) {
4444 this.value = '';
4545 $input.removeClass( 'placeholder' );
@@ -58,4 +58,4 @@
5959 });
6060
6161 });
62 -};
\ No newline at end of file
 62+};
Index: trunk/phase3/resources/Resources.php
@@ -24,6 +24,9 @@
2525 'skins.simple' => array(
2626 'styles' => array( 'skins/simple/main.css' => array( 'media' => 'screen' ) ),
2727 ),
 28+ 'skins.chick' => array(
 29+ 'styles' => array( 'skins/chick/main.css' => array( 'media' => 'screen,handheld' ) ),
 30+ ),
2831
2932 /* jQuery */
3033

Follow-up revisions

RevisionCommit summaryAuthorDate
r80777Partial revert of r80772....hartman23:13, 22 January 2011
r84797Followup r80772...hartman13:20, 26 March 2011

Comments

#Comment by Krinkle (talk | contribs)   18:54, 7 March 2011

What about

+		// TODO: Migrate all of these

Right now they are not loaded and could be seen as a regression.

The ones for < IE6 could be dropped as IE5.5 is no longer supported. If there's an easy CSS-hack that can be added to the main stylesheet, there's no need to make it break for IE5.5. But putting an extra conditional comment on every single page in the root HTML for IE5.5 is wasted bandwidth imho.

So that leaves the fixes for IE6 to be reinstated. Marking FIXME.

Status & tagging log