r80697 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r80696‎ | r80697 | r80698 >
Date:19:02, 21 January 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Fold Avars Nogomatch extension into core

No need for an extension just for a wfDebugLog call
Modified paths:
  • /trunk/extensions/Nogomatch (deleted) (history)
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialSearch.php
——@@ -118,6 +118,8 @@
119119 if( !is_null( $t ) ) {
120120 global $wgGoToEdit;
121121 wfRunHooks( 'SpecialSearchNogomatch', array( &$t ) );
 122+ wfDebugLog( 'nogomatch', $t->getText(), false );
 123+
122124 # If the feature is enabled, go straight to the edit page
123125 if( $wgGoToEdit ) {
124126 $wgOut->redirect( $t->getFullURL( array( 'action' => 'edit' ) ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r80893Remove Nogomatch, folded into core in r80697catrope18:42, 24 January 2011
r808941.16wmf4: MFT r80697catrope18:45, 24 January 2011
r808961.16wmf4: Revert r80894 (MFT of r80697), useless on the cluster anywaycatrope18:49, 24 January 2011
r808971.17: MFT r80697, r80755, r80767, r80771, r80773, r80774, r80779, r80816, r80...catrope18:57, 24 January 2011

Comments

#Comment by Raymond (talk | contribs)   11:44, 23 January 2011

Extension seems to be enabled on cluster: http://noc.wikimedia.org/conf/highlight.php?file=CommonSettings.php

If backported to 1.17 it should be removed from /tools/make-wmf-branch/default.conf too

#Comment by Catrope (talk | contribs)   18:42, 24 January 2011

Done in r80893

#Comment by Bryan (talk | contribs)   07:36, 8 February 2011

Removed from config; unmarking scaptrap.

Status & tagging log