r80767 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80766‎ | r80767 | r80768 >
Date:20:38, 22 January 2011
Author:brion
Status:ok
Tags:
Comment:
* (bug 21544) CodeReview commit list: keep long URLs from overflowing out of the comment column on browsers that don't wrap them (eg Chrome 8)

The cells in the comment column have a CSS max-width: 20em set which keeps the column from getting too wide if there's a commit summary with a long word or URL. Setting the overflow to hidden as well keeps these from spilling over to the next column in browsers that don't cleanly wrap them. In some situations 'auto' would be appropriate (provides a scroll bar), but here we're already truncating the message -- it's just a preview, and we want to make sure it fits in the UI.
Modified paths:
  • /trunk/extensions/CodeReview/codereview.css (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/codereview.css
@@ -12,6 +12,7 @@
1313 }
1414 .TablePager_col_cr_message {
1515 max-width: 20em;
 16+ overflow: hidden;
1617 }
1718
1819 .TablePager_col_cr_timestamp {

Follow-up revisions

RevisionCommit summaryAuthorDate
r808971.17: MFT r80697, r80755, r80767, r80771, r80773, r80774, r80779, r80816, r80...catrope18:57, 24 January 2011

Status & tagging log