r80609 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r80608‎ | r80609 | r80610 >
Date:01:20, 20 January 2011
Author:demon
Status:ok (Comments)
Tags:
Comment:
Rm unused assignment of $wgOut. $wgOut needs to be gone from Database code.
Modified paths:
  • /trunk/phase3/includes/db/DatabaseIbm_db2.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseIbm_db2.php
——@@ -114,7 +114,7 @@
115115 protected $mPHPError = false;
116116
117117 protected $mServer, $mUser, $mPassword, $mConn = null, $mDBname;
118 - protected $mOut, $mOpened = false;
 118+ protected $mOpened = false;
119119
120120 protected $mTablePrefix;
121121 protected $mFlags;
——@@ -270,7 +270,6 @@
271271 if ( !isset( $wgOut ) ) {
272272 $wgOut = null;
273273 }
274 - $this->mOut =& $wgOut;
275274 $this->mFlags = DBO_TRX | $flags;
276275
277276 if ( $schema == self::USE_GLOBAL ) {

Comments

#Comment by MaxSem (talk | contribs)   05:53, 20 January 2011

This class stil uses $wgOut for no good reason.

#Comment by 😂 (talk | contribs)   05:56, 20 January 2011

Yeah, it needs removing as discussed on IRC earlier tonight. Duplication in the constructors also needs tidying.

Status & tagging log