r80608 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80607‎ | r80608 | r80609 >
Date:01:04, 20 January 2011
Author:bawolff
Status:ok
Tags:
Comment:
(bug 26716) Provide a link for setup instructions for external editor related preferences. As it stands
no one really knows what they do. This can cause confusion if they get accidently checked or whatever.

Personally I think we should maybe remove these preferences altogether, since external editor can be used without them,
and its unclear how many people use it, but that requires more research into how popular the pref is, etc.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -652,8 +652,8 @@
653653 'tog-shownumberswatching' => 'Show the number of watching users',
654654 'tog-oldsig' => 'Preview of existing signature:',
655655 'tog-fancysig' => 'Treat signature as wikitext (without an automatic link)',
656 -'tog-externaleditor' => 'Use external editor by default (for experts only, needs special settings on your computer)',
657 -'tog-externaldiff' => 'Use external diff by default (for experts only, needs special settings on your computer)',
 656+'tog-externaleditor' => 'Use external editor by default (for experts only, needs special settings on your computer. [http://www.mediawiki.org/wiki/Manual:External_editors More information.])',
 657+'tog-externaldiff' => 'Use external diff by default (for experts only, needs special settings on your computer. [http://www.mediawiki.org/wiki/Manual:External_editors More information.])',
658658 'tog-showjumplinks' => 'Enable "jump to" accessibility links',
659659 'tog-uselivepreview' => 'Use live preview (requires JavaScript) (experimental)',
660660 'tog-forceeditsummary' => 'Prompt me when entering a blank edit summary',
Index: trunk/phase3/RELEASE-NOTES
@@ -98,7 +98,8 @@
9999 * (bug 26449) Keep underlines from headings outside of tables and thumbs by
100100 adding overflow:hidden to h1,h2,h3,h4,h5,h6 (also fixes editsection bunching).
101101 * (bug 26708) Remove background-color:white from tables in Monobook and Vector.
102 -* (bug 26781) {{PAGENAME}} and related parser functions escape their output better
 102+* (bug 26781) {{PAGENAME}} and related parser functions escape their output better.
 103+* (bug 26716) Provide link to instructions for external editor related preferences.
103104
104105 === API changes in 1.18 ===
105106 * (bug 26339) Throw warning when truncating an overlarge API result

Follow-up revisions

RevisionCommit summaryAuthorDate
r80610(bug 26716, well partially anyways. kind of second half of r80608) Add a comm...bawolff01:49, 20 January 2011
r81355MFT r80608.siebrand23:35, 1 February 2011

Status & tagging log