r80322 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80321‎ | r80322 | r80323 >
Date:20:43, 14 January 2011
Author:reedy
Status:ok
Tags:
Comment:
* (bug 26733) Wrap initial table creation in transaction
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/installer/DatabaseInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/DatabaseInstaller.php
@@ -130,10 +130,15 @@
131131 }
132132
133133 $this->db->setFlag( DBO_DDLMODE ); // For Oracle's handling of schema files
 134+ $this->db->begin( __METHOD__ );
 135+
134136 $error = $this->db->sourceFile( $this->db->getSchema() );
135137 if( $error !== true ) {
136138 $this->db->reportQueryError( $error, 0, '', __METHOD__ );
 139+ $this->db->rollback( __METHOD__ );
137140 $status->fatal( 'config-install-tables-failed', $error );
 141+ } else {
 142+ $this->db->commit( __METHOD__ );
138143 }
139144 return $status;
140145 }
Index: trunk/phase3/RELEASE-NOTES
@@ -79,6 +79,7 @@
8080 tab on the mainpage of a wiki.
8181 * (bug 10158) Do not mention allowing others to contact you when the feature
8282 is disabled ($wgEnableUserEmail=false)
 83+* (bug 26733) Wrap initial table creation in transaction
8384
8485 === API changes in 1.18 ===
8586 * (bug 26339) Throw warning when truncating an overlarge API result

Follow-up revisions

RevisionCommit summaryAuthorDate
r805291.17: MFT r80163, r80222, r80223, r80319, r80322, r80472, r80481, r80492catrope23:00, 18 January 2011

Status & tagging log