r80472 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80471‎ | r80472 | r80473 >
Date:23:05, 17 January 2011
Author:hartman
Status:ok
Tags:
Comment:
Followup r80034. Make sure that $rules actually exists, otherwise we might generate errors.
Modified paths:
  • /trunk/phase3/skins/CologneBlue.php (modified) (history)
  • /trunk/phase3/skins/Standard.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/CologneBlue.php
@@ -109,6 +109,7 @@
110110 function setupSkinUserCss( OutputPage $out ){
111111 global $wgContLang;
112112 $qb = $this->qbSetting();
 113+ $rules = array();
113114
114115 if ( 2 == $qb ) { # Right
115116 $rules[] = "#quickbar { position: absolute; right: 4px; }";
Index: trunk/phase3/skins/Standard.php
@@ -22,6 +22,8 @@
2323 function setupSkinUserCss( OutputPage $out ){
2424 global $wgContLang;
2525 $qb = $this->qbSetting();
 26+ $rules = array();
 27+
2628 if ( 2 == $qb ) { # Right
2729 $rules[] = "#quickbar { position: absolute; top: 4px; right: 4px; border-left: 2px solid #000000; }";
2830 $rules[] = "#article, #mw-data-after-content { margin-left: 4px; margin-right: 152px; }";

Follow-up revisions

RevisionCommit summaryAuthorDate
r805291.17: MFT r80163, r80222, r80223, r80319, r80322, r80472, r80481, r80492catrope23:00, 18 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80034Repair quickbar of standard and cologneblue skins to work under Resourceloader....hartman20:22, 11 January 2011

Status & tagging log