r80323 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80322‎ | r80323 | r80324 >
Date:20:43, 14 January 2011
Author:hashar
Status:ok
Tags:
Comment:
Remove debugging issue in user preferences

'tototo' message key does not exist that made the message dropped.
Could have used null as a value but it looks nicer to just set
the value.

Per CR on r80281
Modified paths:
  • /trunk/phase3/includes/Preferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Preferences.php
@@ -330,10 +330,12 @@
331331 $helpMessages[] = $wgEmailConfirmToEdit
332332 ? 'prefs-help-email-required'
333333 : 'prefs-help-email' ;
334 - $helpMessages[] = $wgEnableUserEmail
335 - ? 'prefs-help-email-others'
336 - : 'tototo' ;
337334
 335+ if( $wgEnableUserEmail ) {
 336+ // additional messages when users can send email to each other
 337+ $helpMessages[] = 'prefs-help-email-others';
 338+ }
 339+
338340 $defaultPreferences['emailaddress'] = array(
339341 'type' => $wgAuth->allowPropChange( 'emailaddress' ) ? 'email' : 'info',
340342 'default' => $user->getEmail(),

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80281bug 10158 : do not mention allowing others to contact you if $wgEnableUserEma...hashar16:53, 14 January 2011

Status & tagging log