r80222 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80221‎ | r80222 | r80223 >
Date:00:55, 14 January 2011
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Cleaned up some comments that were in the wrong places, missing, or misleading. Added more information about the CSS hacks being used for IE6 support. Merged some rules that were needlessly broken up into multiple sections.
Modified paths:
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/screen.css
@@ -1,8 +1,16 @@
22 /*
3 - * Any rules which should not be flipped automatically in right-to-left situations should be prepended with @noflip in
4 - * a comment block. Images that should be embedded as base64 data-URLs should be prepended with @embed in a comment
5 - * block.
 3+ * Any rules which should not be flipped automatically in right-to-left situations should be
 4+ * prepended with @noflip in a comment block. Images that should be embedded as base64 data-URLs
 5+ * should be prepended with @embed in a comment block.
 6+ *
 7+ * This style-sheet employs a few CSS trick to accomplish compatibility with a wide range of web
 8+ * browsers. The most common trick is to use some styles in IE6 only. This is accomplished by using
 9+ * a rule that makes things work in IE6, and then following it with a rule that begins with
 10+ * "html > body" or use a child selector ">", which is ignored by IE6 because it does not support
 11+ * the child selector. You can spot this by looking for the "OVERRIDDEN BY COMPLIANT BROWSERS" and
 12+ * "IGNORED BY IE6" comments.
613 */
 14+
715 /* Framework */
816 html,
917 body {
@@ -162,12 +170,8 @@
163171 background-image: url(images/tab-break.png);
164172 background-position: bottom right;
165173 background-repeat: no-repeat;
166 - }
167 - div.vectorTabs li a{
168174 color: #0645ad;
169175 cursor: pointer;
170 - }
171 - div.vectorTabs li a {
172176 font-size: 0.8em;
173177 }
174178 /* IGNORED BY IE6 */
@@ -217,14 +221,15 @@
218222 background-image: url(images/tab-break.png);
219223 background-repeat: no-repeat;
220224 }
 225+ /* This will be flipped - unlike the one above it */
 226+ div#mw-head div.vectorMenu h5 {
 227+ background-position: bottom left;
 228+ margin-left: -1px;
 229+ }
221230 /* IGNORED BY IE6 */
222231 div#mw-head div.vectorMenu > h5 {
223232 background-image: none;
224233 }
225 - div#mw-head div.vectorMenu h5 {
226 - background-position: bottom left;
227 - margin-left: -1px;
228 - }
229234 div#mw-head div.vectorMenu h4 {
230235 display: inline-block;
231236 float: left;
@@ -245,7 +250,8 @@
246251 background-image: url(images/tab-break.png);
247252 background-repeat: no-repeat;
248253 }
249 - div.vectorMenu h5 a{
 254+ /* This will be flipped - unlike the one above it */
 255+ div.vectorMenu h5 a {
250256 background-position: bottom right;
251257 }
252258 /* IGNORED BY IE6 */
@@ -268,7 +274,8 @@
269275 body.rtl div.vectorMenu > div.menu {
270276 margin-left: auto;
271277 }
272 - /* Fixes old versions of FireFox */
 278+ /* IGNORED BY IE6 */
 279+ /* Also fixes old versions of FireFox */
273280 /* @noflip */
274281 body.rtl div.vectorMenu > div.menu,
275282 x:-moz-any-link {
@@ -312,16 +319,14 @@
313320 display: inline-block;
314321 padding: 0.5em;
315322 white-space: nowrap;
 323+ color: #0645ad;
 324+ cursor: pointer;
 325+ font-size: 0.8em;
316326 }
317327 /* IGNORED BY IE6 */
318328 div.vectorMenu li > a {
319329 display: block;
320330 }
321 - div.vectorMenu li a {
322 - color: #0645ad;
323 - cursor: pointer;
324 - font-size: 0.8em;
325 - }
326331 div.vectorMenu li.selected a,
327332 div.vectorMenu li.selected a:visited {
328333 color: #333333;
@@ -390,7 +395,6 @@
391396 background-color: transparent;
392397 direction: ltr;
393398 }
394 - /* OVERRIDDEN BY COMPLIANT BROWSERS */
395399 div#simpleSearch button#searchButton {
396400 padding: 0;
397401 margin: 0 5px;
@@ -399,6 +403,7 @@
400404 background-color: transparent;
401405 font-size: x-small;
402406 }
 407+ /* OVERRIDDEN BY COMPLIANT BROWSERS */
403408 div#simpleSearch button#searchButton img {
404409 border: none;
405410 margin: 0;
@@ -561,7 +566,7 @@
562567 background-position: bottom right;
563568 background-repeat: no-repeat;
564569 }
565 - /* IGNORED BY IE6 */
 570+ /* Sadly, IE6 won't understand this */
566571 #preftoc li:first-child {
567572 margin-left: 1px;
568573 }
@@ -1140,6 +1145,7 @@
11411146 #ca-watch.icon {
11421147 margin-right:1px;
11431148 }
 1149+/* OVERRIDDEN BY COMPLIANT BROWSERS */
11441150 #ca-unwatch.icon a,
11451151 #ca-watch.icon a {
11461152 margin: 0;

Follow-up revisions

RevisionCommit summaryAuthorDate
r805291.17: MFT r80163, r80222, r80223, r80319, r80322, r80472, r80481, r80492catrope23:00, 18 January 2011
r805501.17: MFT r80106, r80137, r80138, r80205, r80210, r80222, r80223, r80231, r80...catrope02:09, 19 January 2011

Comments

#Comment by Kaldari (talk | contribs)   01:25, 14 January 2011

Nice clean-up. Everything looks good.

Status & tagging log