r80106 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80105‎ | r80106 | r80107 >
Date:19:20, 12 January 2011
Author:tparscal
Status:resolved (Comments)
Tags:
Comment:
Fixed watch icon positioning in IE6. Converted PNGs to 8bit to improve appearance in older browsers.
Modified paths:
  • /trunk/phase3/skins/vector/images/arrow-down-icon.png (modified) (history)
  • /trunk/phase3/skins/vector/images/watch-icons.png (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/images/watch-icons.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/phase3/skins/vector/images/arrow-down-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/phase3/skins/vector/screen.css
@@ -1143,11 +1143,18 @@
11441144 width: 26px;
11451145 /* This hides the text but shows the background image */
11461146 padding-top: 3.1em;
 1147+ margin-top: -0.8em;
11471148 height: 0;
11481149 overflow: hidden;
11491150 /* @embed */
11501151 background-image: url(images/watch-icons.png);
11511152 }
 1153+/* IGNORED BY IE6 */
 1154+html > body #ca-unwatch.icon a,
 1155+html > body #ca-watch.icon a {
 1156+ margin-top: 0;
 1157+ padding-top: 3.1em;
 1158+}
11521159 #ca-unwatch.icon a {
11531160 background-position: -43px 60%;
11541161 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r80223Removed redundant padding rule added in r80106.tparscal00:56, 14 January 2011
r805501.17: MFT r80106, r80137, r80138, r80205, r80210, r80222, r80223, r80231, r80...catrope02:09, 19 January 2011

Comments

#Comment by Catrope (talk | contribs)   20:48, 12 January 2011

Removing from my review list. This is CSS magic that I don't understand, someone who does understand it should review this.

#Comment by Kaldari (talk | contribs)   00:33, 14 January 2011

Probably needs a better comment explaining the IE6 hack, so that no one accidently breaks this in the future.

#Comment by Kaldari (talk | contribs)   00:47, 14 January 2011

Also it looks like the padding-top: 3.1em; part is redundant here.

#Comment by Trevor Parscal (WMF) (talk | contribs)   00:57, 14 January 2011

The comments are improved in r80222.

#Comment by Kaldari (talk | contribs)   01:01, 14 January 2011

Looks good.

Status & tagging log