r79970 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79969‎ | r79970 | r79971 >
Date:22:41, 10 January 2011
Author:tparscal
Status:ok
Tags:
Comment:
Changed the way the toolbar creates it's file tool - which inserts [[File:<selection>]] - now we are using the wgFormattedNamespaces configuration. wikieditor-toolbar-tool-file-pre is not needed anymore, and has been removed.
Modified paths:
  • /trunk/extensions/WikiEditor/WikiEditor.i18n.php (modified) (history)
  • /trunk/extensions/WikiEditor/WikiEditor.php (modified) (history)
  • /trunk/extensions/WikiEditor/modules/ext.wikiEditor.toolbar.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/WikiEditor.php
@@ -318,7 +318,6 @@
319319 'wikieditor-toolbar-tool-link-lookslikeinternal-ext',
320320 'wikieditor-toolbar-tool-link-empty',
321321 'wikieditor-toolbar-tool-file',
322 - 'wikieditor-toolbar-tool-file-pre',
323322 'wikieditor-toolbar-tool-file-example',
324323 'wikieditor-toolbar-tool-reference',
325324 'wikieditor-toolbar-tool-reference-title',
Index: trunk/extensions/WikiEditor/modules/ext.wikiEditor.toolbar.js
@@ -153,8 +153,7 @@
154154 'action': {
155155 'type': 'encapsulate',
156156 'options': {
157 - // FIXME: Why the hell was this done this way?
158 - 'preMsg': [ 'wikieditor-toolbar-tool-file-pre', '[[' ],
 157+ 'pre': '[[' + mediaWiki.config.get( 'wgFormattedNamespaces' )[6] + ':',
159158 'periMsg': 'wikieditor-toolbar-tool-file-example',
160159 'post': "]]"
161160 }
Index: trunk/extensions/WikiEditor/WikiEditor.i18n.php
@@ -91,7 +91,6 @@
9292 'wikieditor-toolbar-tool-link-lookslikeinternal-ext' => 'External link',
9393 'wikieditor-toolbar-tool-link-empty' => "You did not enter anything to link to.",
9494 'wikieditor-toolbar-tool-file' => 'Embedded file',
95 - 'wikieditor-toolbar-tool-file-pre' => '$1{{ns:file}}:',
9695 'wikieditor-toolbar-tool-file-example' => 'Example.jpg',
9796 'wikieditor-toolbar-tool-reference' => 'Reference',
9897 'wikieditor-toolbar-tool-reference-example' => 'Insert footnote text here',

Follow-up revisions

RevisionCommit summaryAuthorDate
r79991Follow-up r79970: Remove deleted message from TWN config file too.raymond07:47, 11 January 2011
r802571.17: MFT r79821, r79842, r79970, r79973, r79975, r79978, r80057, r80058, r80...catrope12:35, 14 January 2011

Status & tagging log