r80060 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80059‎ | r80060 | r80061 >
Date:23:55, 11 January 2011
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Improved on r79973 re-resolves #25724 after #80057 re-broke it. Aparently Opera was choking on, and ignoring the following CSS rule after, a CSS rule that ended in "background-image: url(some url here) !important;" Removing the "!important" part fixed the problem, and in this case it didn't seem to be needed anyways. So much for unicorn tears...
Modified paths:
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.css (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.css
@@ -114,7 +114,7 @@
115115 }
116116 .wikiEditor-ui-toolbar .tabs span.tab a.loading {
117117 /* @embed */
118 - background-image: url(images/toolbar/loading-small.gif) !important;
 118+ background-image: url(images/toolbar/loading-small.gif);
119119 }
120120 /* Toolbar */
121121 .wikiEditor-ui-toolbar .group .label {

Follow-up revisions

RevisionCommit summaryAuthorDate
r802571.17: MFT r79821, r79842, r79970, r79973, r79975, r79978, r80057, r80058, r80...catrope12:35, 14 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79973Resolved #25724 using evil black magic and unicorn tears.tparscal23:32, 10 January 2011

Comments

#Comment by Catrope (talk | contribs)   19:23, 12 January 2011

Please use bug 25724 and r80057 to enable auto-linking. In particular, don't use #12345 for both rev and bug numbers.

#Comment by Trevor Parscal (WMF) (talk | contribs)   19:28, 12 January 2011

Arg! microformat fail!

Status & tagging log