r80057 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r80056‎ | r80057 | r80058 >
Date:23:41, 11 January 2011
Author:tparscal
Status:resolved (Comments)
Tags:
Comment:
Removed RTL rules and IE6 stuff from toolbar css, ResourceLoader uses CSSJanus to auto-flip the rules, and IE6 is blacklisted anyways.
Modified paths:
  • /trunk/extensions/WikiEditor/modules/images/toolbar/arrow-left.png (deleted) (history)
  • /trunk/extensions/WikiEditor/modules/images/toolbar/arrow-ltr.png (added) (history)
  • /trunk/extensions/WikiEditor/modules/images/toolbar/arrow-right.png (deleted) (history)
  • /trunk/extensions/WikiEditor/modules/images/toolbar/arrow-rtl.png (added) (history)
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.css (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/modules/images/toolbar/arrow-right.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/WikiEditor/modules/images/toolbar/arrow-left.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/WikiEditor/modules/images/toolbar/arrow-rtl.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/WikiEditor/modules/images/toolbar/arrow-rtl.png
___________________________________________________________________
Added: svn:mime-type
11 + image/png
Index: trunk/extensions/WikiEditor/modules/images/toolbar/arrow-ltr.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/WikiEditor/modules/images/toolbar/arrow-ltr.png
___________________________________________________________________
Added: svn:mime-type
22 + image/png
Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.css
——@@ -13,9 +13,6 @@
1414 clear: both;
1515 height: 0;
1616 }
17 -body.rtl .wikiEditor-ui-toolbar .sections {
18 - float: right;
19 -}
2017 .wikiEditor-ui-toolbar .sections .section {
2118 display: none;
2219 float: left;
——@@ -29,15 +26,13 @@
3027 background-position: left top;
3128 background-repeat: repeat-x;
3229 }
33 -body.rtl .wikiEditor-ui-toolbar .sections .section {
34 - float: right;
35 -}
3630 /* Gets overridden when the section div is in class loading - see below */
3731 .wikiEditor-ui-toolbar .sections div .spinner {
3832 display: none;
3933 }
4034 .wikiEditor-ui-toolbar .sections .loading .spinner {
4135 display: block;
 36+ float: left;
4237 /* @embed */
4338 background-image: url(images/toolbar/loading.gif);
4439 background-position: left center;
——@@ -45,17 +40,8 @@
4641 padding-left: 32px;
4742 margin-left: 0.5em;
4843 height: 32px;
49 - float: left;
5044 color: #666666;
5145 }
52 -body.rtl .wikiEditor-ui-toolbar .sections .loading .spinner {
53 - background-position: right center;
54 - padding-left: 0;
55 - padding-right: 32px;
56 - margin-left: 0;
57 - margin-right: 0.5em;
58 - float: right;
59 -}
6046 /* Top Level Containers */
6147 .wikiEditor-ui-toolbar .tabs,
6248 .wikiEditor-ui-toolbar .section-main {
——@@ -63,10 +49,6 @@
6450 float: left;
6551 height: 26px;
6652 }
67 -body.rtl .wikiEditor-ui-toolbar .tabs,
68 -body.rtl .wikiEditor-ui-toolbar .section-main {
69 - float: right;
70 -}
7153 /* Groups */
7254 .wikiEditor-ui-toolbar .group {
7355 float: left;
——@@ -75,13 +57,6 @@
7658 border-right: solid 1px #DDDDDD;
7759 margin: 3px;
7860 }
79 -body.rtl .wikiEditor-ui-toolbar .group {
80 - float: right;
81 - padding-right: 0;
82 - padding-left: 6px;
83 - border-right: none;
84 - border-left: solid 1px #DDDDDD;
85 -}
8661 .wikiEditor-ui-toolbar .group-search {
8762 float: right;
8863 padding: 0 0 0 6px;
——@@ -91,15 +66,6 @@
9267 .wikiEditor-ui-toolbar .group-insert {
9368 border-right: none;
9469 }
95 -body.rtl .wikiEditor-ui-toolbar .group-search {
96 - float: left;
97 - padding: 0 6px 0 0;
98 - border-left: none;
99 - border-right: 1px solid #DDDDDD;
100 -}
101 -body.rtl .wikiEditor-ui-toolbar .group-insert {
102 - border-left: none;
103 -}
10470 /* Sprited Buttons */
10571 .wikiEditor-toolbar-spritedButton {
10672 /* @embed */
——@@ -119,18 +85,13 @@
12086 margin: 3px;
12187 }
12288 .wikiEditor-ui-toolbar .tabs span.tab {
123 - display: inline-block;
 89+ display: block;
12490 float: left;
12591 line-height: 26px;
12692 }
127 -/* IGNORED BY IE6 */
128 -.wikiEditor-ui-toolbar .tabs > span.tab {
129 - display: block;
 93+html.ie-6 .wikiEditor-ui-toolbar .tabs span.tab {
 94+ display: inline-block;
13095 }
131 -/* IGNORED BY IE6 */
132 -body.rtl .wikiEditor-ui-toolbar .tabs > span.tab {
133 - float: right;
134 -}
13596 .wikiEditor-ui-toolbar .tabs span.tab a,
13697 .wikiEditor-ui-toolbar .tabs span.tab a:visited {
13798 display: inline-block;
——@@ -141,34 +102,16 @@
142103 cursor: pointer;
143104 color: #0645ad;
144105 /* @embed */
145 - background-image: url(images/toolbar/arrow-right.png);
 106+ background-image: url(images/toolbar/arrow-ltr.png);
146107 background-position: left center;
147108 background-repeat: no-repeat;
148109 }
149 -body.rtl .wikiEditor-ui-toolbar .tabs span.tab a,
150 -body.rtl .wikiEditor-ui-toolbar .tabs span.tab a:visited {
151 - padding-left: 12px;
152 - padding-right: 18px;
153 - /* @embed */
154 - background-image: url(images/toolbar/arrow-left.png);
155 - background-position: right center;
156 -}
157 -/* IGNORED BY IE6 */
158 -body.rtl .wikiEditor-ui-toolbar .tabs > span.tab > a,
159 -body.rtl .wikiEditor-ui-toolbar .tabs > pan.tab > a:visited {
160 - float: right;
161 -}
162110 .wikiEditor-ui-toolbar .tabs span.tab a.current,
163111 .wikiEditor-ui-toolbar .tabs span.tab a.current:visited {
164112 color: #333333;
165113 /* @embed */
166114 background-image: url(images/toolbar/arrow-down.png);
167115 }
168 -body.rtl .wikiEditor-ui-toolbar .tabs span.tab a.current,
169 -body.rtl .wikiEditor-ui-toolbar .tabs span.tab a.current:visited {
170 - /* @embed */
171 - background-image: url(images/toolbar/arrow-down.png);
172 -}
173116 .wikiEditor-ui-toolbar .tabs span.tab a.current:hover {
174117 text-decoration: none;
175118 }
——@@ -177,15 +120,6 @@
178121 background-image: url(images/toolbar/loading-small.gif) !important;
179122 }
180123 /* Toolbar */
181 -/* IGNORED BY IE6
182 - * BEWARE: For unknown reasons, Opera ignores the ".wikiEditor-ui-toolbar" .group .label rule
183 - * except for when this rule is directly before it.
184 - */
185 -body.rtl .wikiEditor-ui-toolbar .group > .label {
186 - float: right;
187 - margin-left: 8px;
188 - margin-right: 5px;
189 -}
190124 .wikiEditor-ui-toolbar .group .label {
191125 float: left;
192126 border: 0px;
——@@ -205,10 +139,6 @@
206140 padding: 2px;
207141 cursor: pointer;
208142 }
209 -/* IGNORED BY IE6 */
210 -body.rtl .wikiEditor-ui-toolbar .group > img.tool {
211 - float: right;
212 -}
213143 .wikiEditor-ui-toolbar .group .tool-select {
214144 float: left;
215145 margin: 2px;
——@@ -220,10 +150,6 @@
221151 cursor: pointer;
222152 background-color: #ffffff;
223153 }
224 -/* IGNORED BY IE6 */
225 -body.rtl .wikiEditor-ui-toolbar .group > .tool-select {
226 - float: right;
227 -}
228154 .wikiEditor-ui-toolbar .group .tool-select .label {
229155 /* @embed */
230156 background-image: url(images/toolbar/arrow-down.png);
——@@ -238,31 +164,17 @@
239165 text-decoration: none;
240166 color: #333333;
241167 }
242 -body.rtl .wikiEditor-ui-toolbar .group .tool-select .label {
243 - background-position: center left;
244 - padding-right: 4px;
245 - padding-left: 22px;
246 - margin-left: 4px;
247 - margin-right: 0;
248 -}
249 -body.rtl .wikiEditor-ui-toolbar .group .tool-select .menu {
250 - clear: both;
251 -}
252168 .wikiEditor-ui-toolbar .group .tool-select .menu .options {
253169 position: absolute;
254170 display: none;
255171 margin-left: -1px;
 172+ margin-top: 22px;
256173 border: solid 1px silver;
257174 background-color: #ffffff;
258175 }
259 -body.rtl .wikiEditor-ui-toolbar .group .tool-select .menu {
260 - margin-left: -1px;
261 - margin-right: -1px;
 176+html.ie-6 .wikiEditor-ui-toolbar .group .tool-select .options {
 177+ margin-top: 0;
262178 }
263 -/* IGNORED BY IE6 */
264 -.wikiEditor-ui-toolbar .group .tool-select .options {
265 - margin-top: 22px;
266 -}
267179 .wikiEditor-ui-toolbar .group .tool-select .options .option {
268180 display: block;
269181 padding: 0.5em;
——@@ -296,19 +208,12 @@
297209 height: 125px;
298210 overflow: auto;
299211 }
300 -body.rtl .wikiEditor-ui-toolbar .booklet .index {
301 - float: right;
302 -}
303212 .wikiEditor-ui-toolbar .booklet .index div {
304213 padding: 4px;
305214 padding-left: 6px;
306215 cursor: pointer;
307216 color: #0645ad;
308217 }
309 -body.rtl .wikiEditor-ui-toolbar .booklet .index div {
310 - padding-left: 4px;
311 - padding-right: 6px;
312 -}
313218 .wikiEditor-ui-toolbar .booklet .index .current {
314219 background-color: #FAFAFA;
315220 color: #333333;
——@@ -321,9 +226,6 @@
322227 overflow: auto;
323228 background-color: #FAFAFA;
324229 }
325 -body.rtl .wikiEditor-ui-toolbar .booklet .pages {
326 - float: left;
327 -}
328230 /* Help Pages */
329231 .wikiEditor-ui-toolbar .page-table table {
330232 padding-left: 5px;
——@@ -343,10 +245,6 @@
344246 padding: 5px;
345247 margin: 0px;
346248 }
347 -body.rtl .wikiEditor-ui-toolbar .page-table th,
348 -body.rtl .wikiEditor-ui-toolbar .page-table td {
349 - text-align: right;
350 -}
351249 .wikiEditor-ui-toolbar .section-help .page-table td.cell-syntax,
352250 .wikiEditor-ui-toolbar .section-help .page-table td.syntax {
353251 font-family: monospace;
——@@ -378,12 +276,8 @@
379277 font-family: monospace;
380278 font-size: 1.25em;
381279 }
382 -body.rtl .wikiEditor-ui-toolbar .page-characters > div > span,
383280 .wikiEditor-ui-toolbar .page-characters div[dir=rtl] span {
384281 direction: rtl;
385 - float: right;
386 - margin-left: 0;
387 - margin-right: 5px;
388282 }
389283 .wikiEditor-ui-toolbar .page-characters div span:hover {
390284 background-color: white;

Follow-up revisions

RevisionCommit summaryAuthorDate
r802571.17: MFT r79821, r79842, r79970, r79973, r79975, r79978, r80057, r80058, r80...catrope12:35, 14 January 2011

Comments

#Comment by Catrope (talk | contribs)   20:36, 12 January 2011 
+html.ie-6 .wikiEditor-ui-toolbar .tabs span.tab {
+	display: inline-block;
[...]
+html.ie-6 .wikiEditor-ui-toolbar .group .tool-select .options  {
+	margin-top: 0;

In spite of the commit summary, you seem to have added IE6 rules anyway.

#Comment by Catrope (talk | contribs)   20:37, 12 January 2011

Never mind, fixed in r80058. Please use followup marking in the future.

Status & tagging log