r79973 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r79972‎ | r79973 | r79974 >
Date:23:32, 10 January 2011
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Resolved #25724 using evil black magic and unicorn tears.
Modified paths:
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.css (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.css
——@@ -177,6 +177,15 @@
178178 background-image: url(images/toolbar/loading-small.gif) !important;
179179 }
180180 /* Toolbar */
 181+/* IGNORED BY IE6
 182+ * BEWARE: For unknown reasons, Opera ignores the ".wikiEditor-ui-toolbar" .group .label rule
 183+ * except for when this rule is directly before it.
 184+ */
 185+body.rtl .wikiEditor-ui-toolbar .group > .label {
 186+ float: right;
 187+ margin-left: 8px;
 188+ margin-right: 5px;
 189+}
181190 .wikiEditor-ui-toolbar .group .label {
182191 float: left;
183192 border: 0px;
——@@ -188,12 +197,6 @@
189198 color: #777777;
190199 cursor: default;
191200 }
192 -/* IGNORED BY IE6 */
193 -body.rtl .wikiEditor-ui-toolbar .group > .label {
194 - float: right;
195 - margin-left: 8px;
196 - margin-right: 5px;
197 -}
198201 .wikiEditor-ui-toolbar .group img.tool {
199202 float: left;
200203 border: 0px;

Follow-up revisions

RevisionCommit summaryAuthorDate
r80060Improved on r79973 re-resolves #25724 after #80057 re-broke it. Aparently Ope...tparscal23:55, 11 January 2011
r802571.17: MFT r79821, r79842, r79970, r79973, r79975, r79978, r80057, r80058, r80...catrope12:35, 14 January 2011

Comments

#Comment by Reedy (talk | contribs)   01:49, 11 January 2011

bug 25724

#Comment by Aaron Schulz (talk | contribs)   04:10, 11 January 2011

"unicorn tears"...I'll have to remember that one.

#Comment by Catrope (talk | contribs)   09:42, 11 January 2011

Why is there a body.rtl rule here? Won't that be broken by CSSJanus?

#Comment by Trevor Parscal (WMF) (talk | contribs)   18:05, 11 January 2011

Yes, and that's why today I am going to convert this, and the other WikiEditor stylesheets to no longer use manual RTL style, but instead make use of CSSJanus. But it's not as simple just removing the RTL rules, because IE6 is incompatible with the RTL flipping for tool icons, so I have to make it so CSSJanus flips things, but there are some IE6 overrides - so these rules will likely be inverted, but still have body.rtl at the root of the selector and ONLY select IE6 instead of selecting everything except IE6 - and be preceded with a /* @noflip */.

I will watch closely for regressions on this when I do that...

#Comment by Catrope (talk | contribs)   19:40, 11 January 2011

Awesome!

Yeah, there'll be some weird cases, but basically the litmus test is that every body.rtl rule also must have @noflip, or it just doesn't make sense.

While you're on this, also watch out for bug 26665 (now fixed, be careful not to break it again) and maybe look at bug 26589 while you're in there.

Status & tagging log