r79838 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79837‎ | r79838 | r79839 >
Date:19:51, 7 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r66267, usage of $revisionInfo is undefined, but isset is on $uploadInfo, guessing the usages wanted to be $uploadInfo
Modified paths:
  • /trunk/phase3/includes/ImportXMLReader.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImportXMLReader.php
@@ -576,10 +576,10 @@
577577 $revision->setComment( $uploadInfo['comment'] );
578578
579579 if ( isset( $uploadInfo['contributor']['ip'] ) ) {
580 - $revision->setUserIP( $revisionInfo['contributor']['ip'] );
 580+ $revision->setUserIP( $uploadInfo['contributor']['ip'] );
581581 }
582582 if ( isset( $uploadInfo['contributor']['username'] ) ) {
583 - $revision->setUserName( $revisionInfo['contributor']['username'] );
 583+ $revision->setUserName( $uploadInfo['contributor']['username'] );
584584 }
585585
586586 return $this->uploadCallback( $revision );

Follow-up revisions

RevisionCommit summaryAuthorDate
r799171.17: MFT r78554, r79166, r79702, r79746, r79812, r79835, r79838, r79846, r79...catrope21:07, 9 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66267Rewrite of XML Dump Processing:...werdna13:28, 12 May 2010

Status & tagging log