r79702 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r79701‎ | r79702 | r79703 >
Date:02:15, 6 January 2011
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Per fixme on r66822, change index to CREATE INDEX /*i*/ar_page_revid ON /*_*/archive (ar_rev_id);
Modified paths:
  • /trunk/phase3/maintenance/tables.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tables.sql
——@@ -419,7 +419,7 @@
420420
421421 CREATE INDEX /*i*/name_title_timestamp ON /*_*/archive (ar_namespace,ar_title,ar_timestamp);
422422 CREATE INDEX /*i*/ar_usertext_timestamp ON /*_*/archive (ar_user_text,ar_timestamp);
423 -CREATE INDEX /*i*/ar_page_revid ON /*_*/archive (ar_namespace, ar_title, ar_rev_id);
 423+CREATE INDEX /*i*/ar_page_revid ON /*_*/archive (ar_rev_id);
424424
425425
426426 --

Follow-up revisions

RevisionCommit summaryAuthorDate
r79746Followup r79702, r66793, r66822...reedy19:27, 6 January 2011
r799171.17: MFT r78554, r79166, r79702, r79746, r79812, r79835, r79838, r79846, r79...catrope21:07, 9 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66822Fix index creationwerdna12:31, 24 May 2010

Comments

#Comment by Catrope (talk | contribs)   13:48, 6 January 2011

How important is this? Would any queries benefit from doing the index this way?

If it's important, there should be an updater patch to drop and recreate the index on old installs, and the index should be renamed to reflect its new field list.

#Comment by Reedy (talk | contribs)   15:33, 6 January 2011

I was thinking about that last night...

In andrews revision (the one this follows up), he just changed it. One presumed that this meant it was added somepoint in this revision, but it's difficult to tell

I'll followup on this later on and find out when the index was added, and then, as such, we can work a way forward.

#Comment by Reedy (talk | contribs)   15:55, 6 January 2011

Seems to be from Special:Code/MediaWiki/66793:

Ugly temporary fix for bug 21279:

  • When a revision cannot be found in the revision table, look for it in the archive table.
  • If both deleted and undeleted revisions are covered by the same log entry, show two links (see bug 23663)

bug 21279 is still open. I guess that means we probably want to add a patch to add this index, as it wasn't done originally, but was done on the fly... Some people who installed 1.17 from svn might have this... Do we want to rename this index, and do a conditional drop on the one above?

#Comment by Catrope (talk | contribs)   17:29, 6 January 2011

Sounds good. Didn't realize r66793 didn't add the index properly in the first place.

#Comment by Reedy (talk | contribs)   19:28, 6 January 2011

All tidied up in r79746

Status & tagging log