r79917 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79916‎ | r79917 | r79918 >
Date:21:07, 9 January 2011
Author:catrope
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/REL1_17/extensions/LiquidThreads/README (modified) (history)
  • /branches/REL1_17/phase3/README (modified) (history)
  • /branches/REL1_17/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_17/phase3/includes/DefaultSettings.php (modified) (history)
  • /branches/REL1_17/phase3/includes/ImportXMLReader.php (modified) (history)
  • /branches/REL1_17/phase3/includes/MimeMagic.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/MysqlUpdater.php (modified) (history)
  • /branches/REL1_17/phase3/includes/specials/SpecialPrefixindex.php (modified) (history)
  • /branches/REL1_17/phase3/index.php (modified) (history)
  • /branches/REL1_17/phase3/languages/Names.php (modified) (history)
  • /branches/REL1_17/phase3/maintenance/archives/patch-archive_ar_revid.sql (added) (history)
  • /branches/REL1_17/phase3/maintenance/archives/patch-archive_kill_ar_page_revid.sql (added) (history)
  • /branches/REL1_17/phase3/maintenance/tables.sql (modified) (history)
  • /branches/REL1_17/phase3/skins/common/edit.js (modified) (history)

Diff [purge]

Index: branches/REL1_17/extensions/LiquidThreads/README
@@ -34,36 +34,19 @@
3535 'Summary_talk' => 103
3636 );
3737
38 -UPGRADES:
39 -========
40 -
41 -If you are upgrading from an earlier version of Liquid Threads, instead of
42 -sourcing lqt.sql, you should source the appropriate schema change files, in
43 -order:
44 -
45 -lqt-schema-change-1.sql for before r25931
46 -lqt-schema-change-2.sql for before r26550
47 -lqt-schema-change-3.sql for before r26563
48 -lqt-schema-change-4.sql for before r26575
49 -lqt-schema-change-5.sql for before r28178
50 -lqt-schema-change-6.sql for before r28693
51 -
52 -Also, as of 1.14alpha (r39905), the entry point for LiquidThreads is "extensions/
53 -LiquidThreads/LiquidThreads.php" previously, it had ended in "LqtPages.php."
54 -Wikis upgrading with an older configuration need to update this when installing
55 -newer versions, or LiquidThreads will not work.
56 -
5738 CONTACT:
5839 =======
5940
60 -* David McCabe
61 -* davemccabe@gmail.com (email or jabber)
62 -* davidmccabe in #mediawiki on irc.freenode.net
 41+* Andrew Garrett
 42+* agarrett@wikimedia.org
 43+* werdna in #mediawiki on irc.freenode.net
6344
6445 CREDITS:
6546 =======
6647
67 -Written by David McCabe, sponsered by COL.org, Wikia.com, and the Google
 48+Originally written by David McCabe, sponsered by COL.org, Wikia.com, and the Google
6849 Summer of Code, with lots of help from Erik Möller, Brion Vibber, and the kind
6950 folks on #mediawiki.
7051
 52+Now maintained by Andrew Garrett from the Wikimedia Foundation
 53+
Index: branches/REL1_17/phase3/maintenance/archives/patch-archive_ar_revid.sql
@@ -0,0 +1,4 @@
 2+-- Hopefully temporary index.
 3+-- For https://bugzilla.wikimedia.org/show_bug.cgi?id=21279
 4+ALTER TABLE /*$wgDBprefix*/archive
 5+ ADD INDEX ar_revid ( ar_rev_id );
\ No newline at end of file
Property changes on: branches/REL1_17/phase3/maintenance/archives/patch-archive_ar_revid.sql
___________________________________________________________________
Added: svn:eol-style
16 + native
Index: branches/REL1_17/phase3/maintenance/archives/patch-archive_kill_ar_page_revid.sql
@@ -0,0 +1,4 @@
 2+-- Used for killing the wrong index added during SVN for 1.17
 3+-- Won't affect most people, but it doesn't need to exist
 4+ALTER TABLE /*$wgDBprefix*/archive
 5+ DROP INDEX ar_page_revid;
\ No newline at end of file
Property changes on: branches/REL1_17/phase3/maintenance/archives/patch-archive_kill_ar_page_revid.sql
___________________________________________________________________
Added: svn:eol-style
16 + native
Index: branches/REL1_17/phase3/maintenance/tables.sql
@@ -419,7 +419,7 @@
420420
421421 CREATE INDEX /*i*/name_title_timestamp ON /*_*/archive (ar_namespace,ar_title,ar_timestamp);
422422 CREATE INDEX /*i*/ar_usertext_timestamp ON /*_*/archive (ar_user_text,ar_timestamp);
423 -CREATE INDEX /*i*/ar_page_revid ON /*_*/archive (ar_namespace, ar_title, ar_rev_id);
 423+CREATE INDEX /*i*/ar_revid ON /*_*/archive (ar_rev_id);
424424
425425
426426 --
Property changes on: branches/REL1_17/phase3/maintenance/tables.sql
___________________________________________________________________
Modified: svn:mergeinfo
427427 Merged /trunk/phase3/maintenance/tables.sql:r79166,79702,79746
Index: branches/REL1_17/phase3/skins/common/edit.js
@@ -78,7 +78,7 @@
7979 // apply tagOpen/tagClose to selection in textarea,
8080 // use sampleText instead of selection if there is none
8181 window.insertTags = function( tagOpen, tagClose, sampleText ) {
82 - if ( typeof $ != 'undefined' && typeof $.fn.textSelection != 'undefined' &&
 82+ if ( typeof $ != 'undefined' && typeof $.fn.textSelection != 'undefined' && currentFocused &&
8383 ( currentFocused.nodeName.toLowerCase() == 'iframe' || currentFocused.id == 'wpTextbox1' ) ) {
8484 $( '#wpTextbox1' ).textSelection(
8585 'encapsulateSelection', { 'pre': tagOpen, 'peri': sampleText, 'post': tagClose }
Property changes on: branches/REL1_17/phase3/skins/common/edit.js
___________________________________________________________________
Added: svn:mergeinfo
8686 Merged /branches/sqlite/skins/common/edit.js:r58211-58321
8787 Merged /trunk/phase3/skins/common/edit.js:r79166,79746,79865
8888 Merged /branches/new-installer/phase3/skins/common/edit.js:r43664-66004
8989 Merged /branches/REL1_15/phase3/skins/common/edit.js:r51646
Index: branches/REL1_17/phase3/includes/MimeMagic.php
@@ -10,6 +10,19 @@
1111 * This is used as a fallback to mime.types files.
1212 * An extensive list of well known mime types is provided by
1313 * the file mime.types in the includes directory.
 14+ *
 15+ * This list concatenated with mime.types is used to create a mime <-> ext
 16+ * map. Each line contains a mime type followed by a space separated list of
 17+ * extensions. If multiple extensions for a single mime type exist or if
 18+ * multiple mime types exist for a single extension then in most cases
 19+ * MediaWiki assumes that the first extension following the mime type is the
 20+ * canonical extension, and the first time a mime type appears for a certain
 21+ * extension is considered the canonical mime type.
 22+ *
 23+ * (Note that appending $wgMimeTypeFile to the end of MM_WELL_KNOWN_MIME_TYPES
 24+ * sucks because you can't redefine canonical types. This could be fixed by
 25+ * appending MM_WELL_KNOWN_MIME_TYPES behind $wgMimeTypeFile, but who knows
 26+ * what will break? In practice this probably isn't a problem anyway -- Bryan)
1427 */
1528 define('MM_WELL_KNOWN_MIME_TYPES',<<<END_STRING
1629 application/ogg ogx ogg ogm ogv oga spx
@@ -41,9 +54,12 @@
4255 image/gif gif
4356 image/jpeg jpeg jpg jpe
4457 image/png png
45 -image/svg+xml image/svg svg
 58+image/svg+xml svg
 59+image/svg svg
4660 image/tiff tiff tif
47 -image/vnd.djvu image/x.djvu image/x-djvu djvu
 61+image/vnd.djvu djvu
 62+image/x.djvu djvu
 63+image/x-djvu djvu
4864 image/x-portable-pixmap ppm
4965 image/x-xcf xcf
5066 text/plain txt
Property changes on: branches/REL1_17/phase3/includes/MimeMagic.php
___________________________________________________________________
Added: svn:mergeinfo
5167 Merged /branches/new-installer/phase3/includes/MimeMagic.php:r43664-66004
5268 Merged /branches/wmf-deployment/includes/MimeMagic.php:r53381
5369 Merged /branches/REL1_15/phase3/includes/MimeMagic.php:r51646
5470 Merged /branches/sqlite/includes/MimeMagic.php:r58211-58321
5571 Merged /trunk/phase3/includes/MimeMagic.php:r79166,79746,79835
Index: branches/REL1_17/phase3/includes/installer/MysqlUpdater.php
@@ -171,6 +171,8 @@
172172 array( 'doCollationUpdate' ),
173173 array( 'addTable', 'msg_resource', 'patch-msg_resource.sql' ),
174174 array( 'addTable', 'module_deps', 'patch-module_deps.sql' ),
 175+ array( 'dropIndex', 'archive', 'ar_page_revid', 'patch-archive_kill_ar_page_revid.sql' ),
 176+ array( 'addIndex', 'archive', 'ar_revid', 'patch-archive_ar_revid.sql' ),
175177 );
176178 }
177179
Property changes on: branches/REL1_17/phase3/includes/installer/MysqlUpdater.php
___________________________________________________________________
Modified: svn:mergeinfo
178180 Merged /trunk/phase3/includes/installer/MysqlUpdater.php:r79166,79746,79812
Index: branches/REL1_17/phase3/includes/ImportXMLReader.php
@@ -576,10 +576,10 @@
577577 $revision->setComment( $uploadInfo['comment'] );
578578
579579 if ( isset( $uploadInfo['contributor']['ip'] ) ) {
580 - $revision->setUserIP( $revisionInfo['contributor']['ip'] );
 580+ $revision->setUserIP( $uploadInfo['contributor']['ip'] );
581581 }
582582 if ( isset( $uploadInfo['contributor']['username'] ) ) {
583 - $revision->setUserName( $revisionInfo['contributor']['username'] );
 583+ $revision->setUserName( $uploadInfo['contributor']['username'] );
584584 }
585585
586586 return $this->uploadCallback( $revision );
Property changes on: branches/REL1_17/phase3/includes/ImportXMLReader.php
___________________________________________________________________
Added: svn:mergeinfo
587587 Merged /branches/sqlite/includes/ImportXMLReader.php:r58211-58321
588588 Merged /trunk/phase3/includes/ImportXMLReader.php:r79166,79746,79838
589589 Merged /branches/new-installer/phase3/includes/ImportXMLReader.php:r43664-66004
590590 Merged /branches/wmf-deployment/includes/ImportXMLReader.php:r53381
591591 Merged /branches/REL1_15/phase3/includes/ImportXMLReader.php:r51646
Index: branches/REL1_17/phase3/includes/DefaultSettings.php
@@ -3087,11 +3087,6 @@
30883088 * @since 1.17
30893089 */
30903090 $wgSecureLogin = false;
3091 -/**
3092 - * Default for 'use secure login' checkbox
3093 - * @since 1.17
3094 - */
3095 -$wgSecureLoginStickHTTPS = false;
30963091
30973092 /** @} */ # end user accounts }
30983093
Property changes on: branches/REL1_17/phase3/includes/DefaultSettings.php
___________________________________________________________________
Added: svn:mergeinfo
30993094 Merged /branches/REL1_15/phase3/includes/DefaultSettings.php:r51646
31003095 Merged /branches/sqlite/includes/DefaultSettings.php:r58211-58321
31013096 Merged /trunk/phase3/includes/DefaultSettings.php:r79166,79746,79860
31023097 Merged /branches/new-installer/phase3/includes/DefaultSettings.php:r43664-66004
31033098 Merged /branches/wmf-deployment/includes/DefaultSettings.php:r53381
Index: branches/REL1_17/phase3/includes/specials/SpecialPrefixindex.php
@@ -54,12 +54,17 @@
5555 : wfMsg( 'prefixindex' )
5656 );
5757
 58+ $showme = '';
5859 if( isset( $par ) ){
59 - $this->showPrefixChunk( $namespace, $par, $from );
 60+ $showme = $par;
6061 } elseif( $prefix != '' ){
61 - $this->showPrefixChunk( $namespace, $prefix, $from );
 62+ $showme = $prefix;
6263 } elseif( $from != '' ){
63 - $this->showPrefixChunk( $namespace, $from, $from );
 64+ // For back-compat with Special:Allpages
 65+ $showme = $from;
 66+ }
 67+ if ($showme != '' || $namespace) {
 68+ $this->showPrefixChunk( $namespace, $showme, $from );
6469 } else {
6570 $wgOut->addHTML( $this->namespacePrefixForm( $namespace, null ) );
6671 }
Property changes on: branches/REL1_17/phase3/includes/specials/SpecialPrefixindex.php
___________________________________________________________________
Added: svn:mergeinfo
6772 Merged /branches/wmf-deployment/includes/specials/SpecialPrefixindex.php:r53381,56967
6873 Merged /branches/REL1_15/phase3/includes/specials/SpecialPrefixindex.php:r51646
6974 Merged /branches/sqlite/includes/specials/SpecialPrefixindex.php:r58211-58321
7075 Merged /trunk/phase3/includes/specials/SpecialPrefixindex.php:r79166,79746,79851
Index: branches/REL1_17/phase3/index.php
@@ -16,7 +16,8 @@
1717 * Copyright (C) 2001-2010 Magnus Manske, Brion Vibber, Lee Daniel Crocker,
1818 * Tim Starling, Erik Möller, Gabriel Wicke, Ævar Arnfjörð Bjarmason,
1919 * Niklas Laxström, Domas Mituzas, Rob Church, Yuri Astrakhan, Aryeh Gregor,
20 - * Aaron Schulz and others.
 20+ * Aaron Schulz, Andrew Garrett, Raimond Spekking, Alexandre Emsenhuber
 21+ * Siebrand Mazeland, Chad Horohoe, Roan Kattouw and others.
2122 *
2223 * This program is free software; you can redistribute it and/or modify
2324 * it under the terms of the GNU General Public License as published by
Index: branches/REL1_17/phase3/README
@@ -36,6 +36,15 @@
3737 * Yuri Astrakhan
3838 * Aryeh Gregor
3939 * Aaron Schulz
 40+* Andrew Garrett
 41+* Raimond Spekking
 42+* Alexandre Emsenhuber
 43+* Siebrand Mazeland
 44+* Chad Horohoe
 45+* Roan Kattouw
 46+* Trevor Pascal
 47+* Bryan Tong Minh
 48+* Sam Reed
4049 * Several others (view CREDITS for a more complete list)
4150
4251 The contributors hold the copyright to this work, and it is licensed under the
Property changes on: branches/REL1_17/phase3/README
___________________________________________________________________
Added: svn:mergeinfo
4352 Merged /branches/sqlite/README:r58211-58321
4453 Merged /trunk/phase3/README:r79166,79746,79846
4554 Merged /branches/new-installer/phase3/README:r43664-66004
4655 Merged /branches/REL1_15/phase3/README:r51646
Index: branches/REL1_17/phase3/languages/Names.php
@@ -27,7 +27,7 @@
2828 'avk' => 'Kotava', # Kotava
2929 'ay' => 'Aymar aru', # Aymara
3030 'az' => 'Azərbaycanca', # Azerbaijani
31 - 'ba' => 'Башҡорт', # Bashkir
 31+ 'ba' => 'Башҡортса', # Bashkir
3232 'bar' => 'Boarisch', # Bavarian (Austro-Bavarian and South Tyrolean)
3333 'bat-smg' => 'Žemaitėška', # Samogitian (deprecated code, 'sgs' in ISO 693-3 since 2010-06-30 )
3434 'bcc' => 'بلوچی مکرانی', # Southern Balochi
Property changes on: branches/REL1_17/phase3/languages/Names.php
___________________________________________________________________
Added: svn:mergeinfo
3535 Merged /branches/sqlite/languages/Names.php:r58211-58321
3636 Merged /trunk/phase3/languages/Names.php:r79166,79746,79894
3737 Merged /branches/new-installer/phase3/languages/Names.php:r43664-66004
3838 Merged /branches/REL1_15/phase3/languages/Names.php:r51646
Index: branches/REL1_17/phase3/RELEASE-NOTES
@@ -83,7 +83,7 @@
8484 without having to move LocalSettings.php
8585 * The FailFunction "error handling" method has now been removed
8686 * $wgAdditionalMailParams added to allow setting extra options to mail() calls.
87 -* $wgSecureLogin & $wgSecureLoginStickHTTPS to optionaly login using HTTPS
 87+* $wgSecureLogin to optionaly login using HTTPS
8888 * (bug 25728) Added $wgPasswordSenderName to allow customise the name associed
8989 with $wgPasswordSender
9090 * Sysops now have the "suppressredirect" right by default
Property changes on: branches/REL1_17/phase3/RELEASE-NOTES
___________________________________________________________________
Added: svn:mergeinfo
9191 Merged /branches/new-installer/phase3/RELEASE-NOTES:r43664-66004
9292 Merged /branches/REL1_15/phase3/RELEASE-NOTES:r51646
9393 Merged /trunk/phase3/HISTORY:r79860
9494 Merged /branches/sqlite/RELEASE-NOTES:r58211-58321
9595 Merged /trunk/phase3/RELEASE-NOTES:r79166,79746

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78554Updatewerdna01:31, 18 December 2010
r79166Add main contributors in SpecialVersion to README and index.php as wellbtongminh11:57, 29 December 2010
r79702Per fixme on r66822, change index to CREATE INDEX /*i*/ar_page_revid ON /*_*/...reedy02:15, 6 January 2011
r79746Followup r79702, r66793, r66822...reedy19:27, 6 January 2011
r79812Fix indentation in r79746catrope12:59, 7 January 2011
r79835Document how the mime<->extension map is supposed to work, to my best underst...btongminh19:41, 7 January 2011
r79838Followup r66267, usage of $revisionInfo is undefined, but isset is on $upload...reedy19:51, 7 January 2011
r79846Follow-up r79713: add authors to README as wellbtongminh22:13, 7 January 2011
r79851* (bug 26625) fix regression in Special:PrefixIndex from r75314; pages weren'...brion23:52, 7 January 2011
r79860Removes $wgSecureLoginStickHTTPS which was never really used...hashar13:06, 8 January 2011
r79865(bug 26620) JavaScript error in insertTags() when jQuery is present but curre...catrope16:06, 8 January 2011
r79894Bug 25010 - Bashkir-language interwikis: linktext change from Башҡорт ...nikerabbit12:56, 9 January 2011

Status & tagging log