r79746 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79745‎ | r79746 | r79747 >
Date:19:27, 6 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r79702, r66793, r66822

Add patch to kill bad original ar_page_revid index (did exist as 2 definitions under the same name). Add patch to add index ar_revid per FIXME, though, hopefully only a temporary index

Updated tables.sql with new index
Modified paths:
  • /trunk/phase3/includes/installer/MysqlUpdater.php (modified) (history)
  • /trunk/phase3/maintenance/archives/patch-archive_ar_revid.sql (added) (history)
  • /trunk/phase3/maintenance/archives/patch-archive_kill_ar_page_revid.sql (added) (history)
  • /trunk/phase3/maintenance/tables.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/MysqlUpdater.php
@@ -171,6 +171,8 @@
172172 array( 'doCollationUpdate' ),
173173 array( 'addTable', 'msg_resource', 'patch-msg_resource.sql' ),
174174 array( 'addTable', 'module_deps', 'patch-module_deps.sql' ),
 175+ array( 'dropIndex', 'archive', 'ar_page_revid', 'patch-archive_kill_ar_page_revid.sql' ),
 176+ array( 'addIndex', 'archive', 'ar_revid', 'patch-archive_ar_revid.sql' ),
175177 );
176178 }
177179
Index: trunk/phase3/maintenance/tables.sql
@@ -419,7 +419,7 @@
420420
421421 CREATE INDEX /*i*/name_title_timestamp ON /*_*/archive (ar_namespace,ar_title,ar_timestamp);
422422 CREATE INDEX /*i*/ar_usertext_timestamp ON /*_*/archive (ar_user_text,ar_timestamp);
423 -CREATE INDEX /*i*/ar_page_revid ON /*_*/archive (ar_rev_id);
 423+CREATE INDEX /*i*/ar_revid ON /*_*/archive (ar_rev_id);
424424
425425
426426 --
Index: trunk/phase3/maintenance/archives/patch-archive_ar_revid.sql
@@ -0,0 +1,4 @@
 2+-- Hopefully temporary index.
 3+-- For https://bugzilla.wikimedia.org/show_bug.cgi?id=21279
 4+ALTER TABLE /*$wgDBprefix*/archive
 5+ ADD INDEX ar_revid ( ar_rev_id );
\ No newline at end of file
Property changes on: trunk/phase3/maintenance/archives/patch-archive_ar_revid.sql
___________________________________________________________________
Added: svn:eol-style
16 + native
Index: trunk/phase3/maintenance/archives/patch-archive_kill_ar_page_revid.sql
@@ -0,0 +1,4 @@
 2+-- Used for killing the wrong index added during SVN for 1.17
 3+-- Won't affect most people, but it doesn't need to exist
 4+ALTER TABLE /*$wgDBprefix*/archive
 5+ DROP INDEX ar_page_revid;
\ No newline at end of file
Property changes on: trunk/phase3/maintenance/archives/patch-archive_kill_ar_page_revid.sql
___________________________________________________________________
Added: svn:eol-style
16 + native

Follow-up revisions

RevisionCommit summaryAuthorDate
r79812Fix indentation in r79746catrope12:59, 7 January 2011
r799171.17: MFT r78554, r79166, r79702, r79746, r79812, r79835, r79838, r79846, r79...catrope21:07, 9 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66793Ugly temporary fix for bug 21279:...werdna14:19, 23 May 2010
r66822Fix index creationwerdna12:31, 24 May 2010
r79702Per fixme on r66822, change index to CREATE INDEX /*i*/ar_page_revid ON /*_*/...reedy02:15, 6 January 2011

Status & tagging log