r79214 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79213‎ | r79214 | r79215 >
Date:22:30, 29 December 2010
Author:catrope
Status:ok
Tags:
Comment:
Fix r79213: and $ts === null too, per CR
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -1948,7 +1948,7 @@
19491949 $da = array();
19501950 $strtime = '';
19511951
1952 - if ( $ts == 0 ) { // This intentionally catches $ts === '' too, so DON'T change this to ===
 1952+ if ( $ts == 0 ) { // This intentionally catches $ts === '' and $ts === null too, so DON'T change this to ===
19531953 $uts = time();
19541954 $strtime = "@$uts";
19551955 } elseif ( preg_match( '/^(\d{4})\-(\d\d)\-(\d\d) (\d\d):(\d\d):(\d\d)$/D', $ts, $da ) ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r793731.17: MFT r78308, r78622, r79089, r79185, r79199, r79213, r79214, r79253catrope21:09, 31 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79213Followup r71751: change strict comparison to loose per CR, and add a comment ...catrope22:28, 29 December 2010

Status & tagging log