r79185 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r79184‎ | r79185 | r79186 >
Date:16:42, 29 December 2010
Author:platonides
Status:ok
Tags:
Comment:
(Bug 26458) Section edit links appear on pages that user does not have right to edit (
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
——@@ -1478,7 +1478,7 @@
14791479 $parserOptions->setIsPrintable( $wgOut->isPrintable() );
14801480
14811481 # Don't show section-edit links on old revisions... this way lies madness.
1482 - if ( !$this->isCurrent() || $wgOut->isPrintable() ) {
 1482+ if ( !$this->isCurrent() || $wgOut->isPrintable() || !$this->mTitle->quickUserCan( 'edit' ) ) {
14831483 $parserOptions->setEditSection( false );
14841484 }
14851485

Follow-up revisions

RevisionCommit summaryAuthorDate
r793731.17: MFT r78308, r78622, r79089, r79185, r79199, r79213, r79214, r79253catrope21:09, 31 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70498Change quickUserCan( 'edit' ) and getIsPrintable() into setEditSection( false )...platonides14:37, 5 August 2010

Status & tagging log