r79199 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79198‎ | r79199 | r79200 >
Date:20:32, 29 December 2010
Author:btongminh
Status:ok
Tags:
Comment:
Follow-up to r75282: don't query if there are no pages to query
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryPageProps.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryPageProps.php
@@ -47,6 +47,10 @@
4848
4949 # Only operate on existing pages
5050 $pages = $this->getPageSet()->getGoodTitles();
 51+ if ( !count( $pages ) ) {
 52+ # Nothing to do
 53+ return;
 54+ }
5155
5256 $this->addTables( 'page_props' );
5357 $this->addFields( array( 'pp_page', 'pp_propname', 'pp_value' ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r793731.17: MFT r78308, r78622, r79089, r79185, r79199, r79213, r79214, r79253catrope21:09, 31 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75282Follow-up r70638:...btongminh18:53, 23 October 2010

Status & tagging log